[pull] master from supabase:master #362
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* fix(policies search): replace useUrlState with nuqs There is a bug when typing quickly into the search field on the policies page: because useUrlState naively uses router.replace, which is asynchronous, the search term can get corrupted, e.g., searching for "dummy" might end up with a final value of "dum". Switched to nuqs for better handling. * perf(policies page): memoize and optimize for projects with many tables A project with hundreds of tables will have extremely slow search performance for the policies page, because of heavy rerendering. Made some optimizations: - Memoized to reduce rerendering - Hid filtered-out tables instead of unmounting, so we don't have to remount when the search is cleared * refactor(policies page): pass policies info through context Avoid having a mess of props by creating a PoliciesDataContext to share policy information. * cleanup(policies pages): minor code cleanup, no user-facing changes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )