Skip to content

Conversation

captainmangoC4
Copy link
Collaborator

No description provided.

Copy link

vercel bot commented Dec 11, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
components-library ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 12, 2024 6:52pm

Copy link
Collaborator

@SamusElderg SamusElderg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All looks good! Just a comment in regard to the SVGs kebab-casing, but feel free to ignore for later cleanup as its not blocking/breaking 👍

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not super pressing, but ideally want to change the kebab-case props to camelCase. Like clip-path for instance. It wont break anything, just makes react a bit unhappy so its not a blocker, just if you have the time to do so 👍

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, I always forget this!

@captainmangoC4 captainmangoC4 merged commit f64d25f into main Dec 12, 2024
2 of 3 checks passed
@captainmangoC4 captainmangoC4 deleted the mango/add-extension-icons branch December 12, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants