Skip to content

chore: make all image references use relative paths #96

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 18, 2025
Merged

chore: make all image references use relative paths #96

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .storybook/manager-header.html
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
<link rel="shortcut icon" href="/favicon.ico">
<link rel="icon" type="image/png" href="/logos/apple-touch-icon.png" sizes="192x192">
<link rel="icon" type="image/png" href="./logos/apple-touch-icon.png" sizes="192x192">
2 changes: 1 addition & 1 deletion .storybook/theme.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ export default create({
base: "dark",
brandUrl: "https://code4rena.com",
brandTitle: "Code4rena Storybook",
brandImage: "/logos/c4-logo.svg",
brandImage: "./logos/c4-logo.svg",
brandTarget: "_blank",

// UI
Expand Down
2 changes: 1 addition & 1 deletion src/lib/Avatar/Avatar.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ type Story = StoryObj<typeof Avatar>;

export const ImageAvatar: Story = (args) => <Avatar {...args} />;
ImageAvatar.args = {
imgElement: <img src="/images/default-avatar.png" alt="Placeholder" />,
imgElement: <img src="./images/default-avatar.png" alt="Placeholder" />,
name: "0xJohnWithALongName",
size: 50,
round: 25,
Expand Down
6 changes: 3 additions & 3 deletions src/lib/Avatar/Avatar.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,11 +12,11 @@ const defaultArgs = {
describe("========== Avatar Component - RUNNING TESTS ==========", () => {
test("Renders with image avatar", () => {
const imgElement = (
<img src="/images/default-avatar.png" alt="Placeholder" />
<img src="./images/default-avatar.png" alt="Placeholder" />
);
render(<Avatar imgElement={imgElement} {...defaultArgs} />);
const avatar = screen.getByRole("img");
expect(avatar).toHaveAttribute("src", "/images/default-avatar.png");
expect(avatar).toHaveAttribute("src", "./images/default-avatar.png");
});

test("Renders with initials avatar", () => {
Expand All @@ -27,7 +27,7 @@ describe("========== Avatar Component - RUNNING TESTS ==========", () => {

test("Sets alt text for image avatar", () => {
const imgElement = (
<img src="/images/default-avatar.png" alt="User avatar" />
<img src="./images/default-avatar.png" alt="User avatar" />
);
render(<Avatar imgElement={imgElement} {...defaultArgs} />);
const avatar = screen.getByAltText("User avatar");
Expand Down
2 changes: 1 addition & 1 deletion src/lib/Card/Card.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ SampleComponent.args = {
children: <div>Team lead</div>,
title: "MangoBurger",
imageSize: CardImageSize.MEDIUM,
image: <img src="/images/default-avatar.png" />,
image: <img src="./images/default-avatar.png" />,
imageBorderRadius: CardImageBorderRadius.CIRCLE,
cta: { text: "Follow", onClick: () => console.log("follow") },
variants: [
Expand Down
4 changes: 2 additions & 2 deletions src/lib/ContestTile/ContestTile.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ const defaultArgs = {
endDate: "2030-07-21T18:00:00.000Z",
},
variant: ContestTileVariant.DARK,
sponsorImage: "/logos/apple-touch-icon.png",
sponsorImage: "./logos/apple-touch-icon.png",
sponsorUrl: "https://twitter.com/axelarcore",
title: "Axelar Network",
description: "Decentralized interoperability network.",
Expand Down Expand Up @@ -342,7 +342,7 @@ BountyTile.args = {
languages: ["Rust"] as CodingLanguage[],
},
variant: ContestTileVariant.LIGHT,
sponsorImage: "/logos/apple-touch-icon.png",
sponsorImage: "./logos/apple-touch-icon.png",
sponsorUrl: "https://twitter.com/axelarcore",
title: "Axelar Network",
description: "Decentralized interoperability network."
Expand Down
2 changes: 1 addition & 1 deletion src/lib/NavBar/NavBar.stories.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ SampleComponent.args = {
className: "",
isLoggedIn: false,
hideConnectWalletDropdown: false,
userImage: "/logos/apple-touch-icon.png",
userImage: "./logos/apple-touch-icon.png",
username: "TestUser",
navLinks: [
{ label: "How it works", href: "/how-it-works" },
Expand Down