Skip to content

Fix bad logic that left old PRs in the menu list #42

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 25, 2025
Merged

Fix bad logic that left old PRs in the menu list #42

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 15 additions & 3 deletions cmd/goose/main.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -728,9 +728,21 @@ func (app *App) checkForNewlyBlockedPRs(ctx context.Context) {
app.mu.Unlock()

// Update UI after releasing the lock
// Only update if there are newly blocked PRs
if menuInitialized && len(currentBlocked) > len(previousBlocked) {
log.Print("[BLOCKED] Updating UI for newly blocked PRs")
// Check if the set of blocked PRs has changed
blockedPRsChanged := !reflect.DeepEqual(currentBlocked, previousBlocked)

// Update UI if blocked PRs changed or if we cleaned up stale entries
if menuInitialized && (blockedPRsChanged || removedCount > 0) {
switch {
case len(currentBlocked) > len(previousBlocked):
log.Print("[BLOCKED] Updating UI for newly blocked PRs")
case len(currentBlocked) < len(previousBlocked):
log.Print("[BLOCKED] Updating UI - blocked PRs were removed")
case blockedPRsChanged:
log.Print("[BLOCKED] Updating UI - blocked PRs changed (same count)")
default:
log.Printf("[BLOCKED] Updating UI after cleaning up %d stale entries", removedCount)
}
app.setTrayTitle()
app.updateMenu(ctx)
}
Expand Down
Loading