Feature implementation from commits 8b6ec53..b0630c2 #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erTeam#6510) * Fix[pojavexec]: remove central JNIEnv variables These caused some irreliability, as pojavexec isn't guaranteed to be loaded on the same thread as the call to glfwInit This fixes: - 1.3-1.5.2 setting their window size to 0,0 (and thus not working correctly) - Forge for <1.13 not resizing its window * Fix[egl_bridge]: remove attachEnvs() * Whoops[input_bridge]: remove unnecessary prints
Allows NIO ZipFs to function on old Android versions
Co-authored-by: Duy Tran Khanh <[email protected]>
…"true" Fixes RandomPatches
![codeowlai[bot]](https://avatars.githubusercontent.com/in/1259765?s=60&v=4){kind=small}
| void installLwjglDlopenHook() { | ||
| __android_log_print(ANDROID_LOG_INFO, "LwjglLinkerHook", "Installing LWJGL dlopen() hook"); | ||
| JNIEnv* env = pojav_environ->runtimeJNIEnvPtr_JRE; | ||
| void installLwjglDlopenHook(JNIEnv *env) { |
There was a problem hiding this comment.
🐛 Correctness Issue
Breaking API Change Without Dependency Updates.
The function signature change from installLwjglDlopenHook() to installLwjglDlopenHook(JNIEnv *env) will break all existing callers that don't provide the JNIEnv parameter.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Summary
Refactor JNI Code to Improve Logging and Remove Legacy Workarounds
Overview
This PR refactors the JNI codebase by standardizing logging mechanisms, removing legacy workarounds, and improving function signatures to use explicit parameters instead of global variables.
Change Types
Affected Modules
src/main/jni/ctxbridges/gl_bridge.csrc/main/jni/ctxbridges/osm_bridge.csrc/main/jni/ctxbridges/swap_interval_no_egl.csrc/main/jni/egl_bridge.csrc/main/jni/input_bridge_v3.csrc/main/jni/jvm_hooks/java_exec_hooks.csrc/main/jni/jvm_hooks/lwjgl_dlopen_hook.c