chore: infer RSpec metadata about "type" of test from file location #2268
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Example: the spec/features/ files get the RSpec Metadata "type: :feature" automatically. RSpec docs mentioning this: https://rspec.info/features/8-0/rspec-rails/feature-specs/feature-spec/
olleolleolle
changed the title
| @@ -1,5 +1,3 @@ | |||
| require "spec_helper" | |||
|
|
|||
| RSpec.describe Admin::InvitationsController, type: :controller do | |||
There was a problem hiding this comment.
@olleolleolle should we remove the type here as well? Or do we have to keep it since it's in the admin folder within the controllers folder? Not sure how the metadata inference works exactly.
There was a problem hiding this comment.
Here, too. Every file under spec/controllers and below. Another PR does that removing.
matyikriszta
approved these changes
Aug 15, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This quality-of-life PR configures RSpec's inference of types of test by where they are placed in the filesystem. We follow all the regular conventions, so it ought to just work.
How it works:
type: :modelfor example, for files in spec/models