Tim - clean rewardsPointsSystem.py

rewardsPointsSystem.py

@@ -1,6 +1,6 @@
 """
 
-PROBLEM: Management needs to know how many of each item they are selling each 
+PROBLEM: Management needs to know how many of each item they are selling each
 day and what each customer’s current reward points balance is.
 
 Design a system that parses the log file and:
@@ -11,17 +11,22 @@
 
 - For each purchase, a customer can spend a certain amount of reward points for their purchase.
 - Some customers come to the store multiple times per day.
-- Customers earn 1 reward point for every 18 dollars spent, unless they spend more than $250 per day, in which case they earn 1 reward point for every 17 dollars spent. These reward points are given to the customers at the **end** of each day, not immediately after the purchase.
+- Customers earn 1 reward point for every 18 dollars spent,
+  unless they spend more than $250 per day, in which case they earn
+  1 reward point for every 17 dollars spent. These reward points are given
+  to the customers at the **end** of each day, not immediately after the purchase.
 - For each LogEntry, we want to keep track of:
     - Customer ID
     - Number of reward points used for that purchase
     - List of items purchased and their prices
 
 There can also be malformed logs in which any of the three properties in the LogEntry are 'None'.
 If this is the case, please address them in the following ways:
-- If there is no customer ID, do not count the rewards points. Instead, only calculate the purchase counts for the items
+- If there is no customer ID, do not count the rewards points.
+  Instead, only calculate the purchase counts for the items
 - If there is no rewards points specified, assume rewards points = 0
-- If there is no list of items purchased, then this is an error in the system. Please add this LogEntry to a error log (a list of LogEntry called 'error')
+- If there is no list of items purchased, then this is an error in the system.
+  Please add this LogEntry to a error log (a list of LogEntry called 'error')
 
 Example- this is written in casual terms, and must be modified to actual data structures
 	Items:
@@ -31,71 +36,58 @@
 		- Customer 1 purchased 2 bananas and 1 apple; he used 100 rewards points
 		- Customer 2 purchased 1 banana and 1 apple; she used 0 rewards points
 		- Customer 1 purchased 1 banana; he used 0 rewards points
-
 """
 
-class Item:
-  def __init__(self, itemId, item_price):
-    self.itemId = itemId
-    self.item_price = item_price
-
-from collections import defaultdict    
-
-class RewardsSystem:
-  REWARDS_RATIO_BELOW = 18
-  REWARDS_CUTOFF = 250
-
-  def __init__(self):
-    self.rewards_points = defaultdict(int)
-    self.items_purchased = defaultdict(int)
-
-  def process_log(self, log):
-    amount_spent = defaultdict(int)
-
-    for log_entry in log:
-      customer_id = log_entry[0]
-      reward_points_used = log_entry[1]
-      items_purchased = log_entry[2]
-
-      if not customer_id:
-        total_spent = 0
-        for item in items_purchased:
-          total_spent += item.itemId * item.item_price
 
-          # Update items sold
-          for purchase in items_purchased:
-            self.items_purchased[purchase.itemId] = self.items_purchased.get(purchase.itemId, 0) + 1
+from collections import defaultdict
 
-          items_purchased = len(items_purchased) == 0
-          if items_purchased:
-            raise ValueError('Items purchased were not recorded.')
 
-      else:
-
-        # Subtract rewards points used from customer
-        self.rewards_points[customer_id] -= reward_points_used
-
-        total_spent = 0
-        for item in items_purchased:
-          total_spent += item.itemId * item.item_price
-
-        amount_spent[customer_id] = amount_spent.get(customer_id, 0) + total_spent
-
-        # Update items sold
-        for purchase in items_purchased:
-          self.items_purchased[purchase.itemId] = self.items_purchased.get(purchase.itemId, 0) + 1
-
-        print(self.reward_points)
-
-    # At end of day, award reward points back to customers based on how much they spent
-    for customer_id in amount_spent:
-      # Calculate rewards points received
-      rewards_points = amount_spent[customer_id] // RewardsSystem.REWARDS_RATIO_BELOW
-      if amount_spent > RewardsSystem.REWARDS_CUTOFF:
-        rewards_points =  amount_spent[customer_id] // 17 
+class Item:
+    def __init__(self, itemId, item_price):
+        self.itemId = itemId
+        self.item_price = item_price
 
-      # Update customer rewards points
-      self.rewards_points[customer_id] += rewards_points
 
-  def get_items_purchased(self, item_id):
-    return self.items_purchased[item_id]
+class RewardsSystem:
+    REWARDS_RATIO_BELOW = 18
+    REWARDS_CUTOFF = 250
+
+    def __init__(self):
+        self.rewards_points = defaultdict(int)
+        self.items_purchased = defaultdict(int)
+
+    def get_purchased_item_by_id(self, item_id):
+        return self.items_purchased.get(item_id, 0)
+
+    def process_log(self, log):
+        amount_spent = defaultdict(int)
+
+        for log_entry in log:
+            customer_id = log_entry[0]
+            reward_points_used = log_entry[1] or 0
+            items_purchased = log_entry[2]
+
+            if customer_id:
+                # Subtract rewards points used from customer
+                self.rewards_points[customer_id] -= reward_points_used
+                amount_spent[customer_id] = amount_spent.get(
+                    customer_id, 0) + total_spent
+
+            total_spent = 0
+            for item in items_purchased:
+                total_spent += item.itemId * item.item_price
+
+            # Update items sold
+            for purchase in items_purchased:
+                self.items_purchased[purchase.itemId] = self.get_purchased_item_by_id(
+                    purchase.itemId) + 1
+
+        # At end of day, award reward points back to customers based on how much they spent
+        for customer_id in amount_spent:
+            # Calculate rewards points received
+            rewards_points = amount_spent[customer_id] // RewardsSystem.REWARDS_RATIO_BELOW
+            if amount_spent > RewardsSystem.REWARDS_CUTOFF:
+                rewards_points = amount_spent[customer_id] // 17
+
+            # Update customer rewards points
+            self.rewards_points[customer_id] += rewards_points