Open
Conversation
Author
|
It seems that the checks fail because your development environment is also out-of-date. Please check my modifications with |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
First, let me thank the author for such an awesome theme.
The last time this project is updated is 2 years ago. Now some of the features in this project are out-of-date. So I make such modifications:
javascript:;deprecated byReact.The above modifications will upgrade this project to Gatsby v3, and remove all warnings caused by deprecations.
If the author is willing to accept this PR, for the compatibility issue, I suggest that the author should
gatsby-v3and merge my PR to that one,masterbranch asgatsby-v2and merge my PR tomaster.Thank you!