Fix Sarif 2 message conversion #11
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Also, thanks for making this converter, it is quite useful in CI pipelines 😃 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In Sarif 2.0 and 2.1 the error / warning messages are not directly in the
messageelement, instead they are in themessage.textelement. See GitHub documentation or the Sarif format specification itself.Currently the
Converter2usesresult.Messageas a string, which will simply be converted toMicrosoft.CodeAnalysis.Sarif.Message(the type's name) always. Insteadresult.Message.Textshould be used.Note: in Sarif 2 the message text may contain placeholders for arguments. This PR does not resolve injecting those arguments in place of the placeholders, but that could be a further fix / improvement.