Bump json-server from 0.10.1 to 0.17.4 #4577
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kobenguyent
reviewed
Nov 14, 2024
package.json
Outdated
| "repository": "Codeception/codeceptjs", | ||
| "scripts": { | ||
| "json-server": "./node_modules/json-server/bin/index.js test/data/rest/db.json -p 8010 --watch -m test/data/rest/headers.js", | ||
| "json-server": "npx json-server test/data/rest/db.json -p 8010 --watch -m test/data/rest/headers.js", |
Collaborator
There was a problem hiding this comment.
I guess we don't need npx here.
Contributor
Author
There was a problem hiding this comment.
The old command does not work - if you have a working one - please provide me with it
Contributor
Author
There was a problem hiding this comment.
Ah - see it - will fix
Contributor
Author
|
@kobenguyent Any clue why the Acceptance Tests using docker compose / build (20.x) (pull_request) are failing ? |
Collaborator
I'm thinking of another alternative to this. |
Contributor
Author
|
Found the error - new PR coming up |
32 tasks
Collaborator
As you're looking into this. May you think this alternative is better as we are running tests inside containers https://testcontainers.com/?language=nodejs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation/Description of the PR
Applicable helpers:
Applicable plugins:
Type of change
Checklist:
npm run docs)npm run lint)npm test)