Skip to content

fix(playwright): relaunch browser correctly with restart: 'session' in run-workers --by pool #5118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 28, 2025
Merged

fix(playwright): relaunch browser correctly with restart: 'session' in run-workers --by pool #5118

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
01412b7
fix: Reset browser context and state on close
Samuel-StO Aug 28, 2025
5fe2b51
test: add acceptance tests
Samuel-StO Aug 28, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/playwright.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,9 @@ jobs:
run: './bin/codecept.js run -c test/acceptance/codecept.Playwright.js --grep @Playwright --debug'
- name: run chromium with restart==browser tests
run: 'BROWSER_RESTART=browser ./bin/codecept.js run -c test/acceptance/codecept.Playwright.js --grep @Playwright --debug'
- name: run chromium with restart==session tests
- name: run chromium with restart==session tests on 2 workers split by pool
run: 'BROWSER_RESTART=session ./bin/codecept.js run-workers 2 -c test/acceptance/codecept.Playwright.js --grep @Playwright --debug --by=pool'
- name: run chromium with restart==session tests and
run: 'BROWSER_RESTART=session ./bin/codecept.js run -c test/acceptance/codecept.Playwright.js --grep @Playwright --debug'
- name: run firefox tests
run: 'BROWSER=firefox node ./bin/codecept.js run -c test/acceptance/codecept.Playwright.js --grep @Playwright --debug'
Expand Down
3 changes: 3 additions & 0 deletions lib/helper/Playwright.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1031,7 +1031,10 @@ class Playwright extends Helper {
this.frame = null
popupStore.clear()
if (this.options.recordHar) await this.browserContext.close()
this.browserContext = null
await this.browser.close()
this.browser = null
this.isRunning = false
}

async _evaluateHandeInContext(...args) {
Expand Down