[WIP] Popups triggered during a test execution are not isolated between sequentially executed tests, leading to state leakage #5121
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Fixed popup state leakage between sequentially executed tests in both Playwright and Puppeteer helpers.
Root Cause: The
popupStore
is a global singleton that was never cleared between tests, causing thePopup
class setter to ignore new popups when one already existed.Fix: Added
popupStore.clear()
call in the_after()
method of both helpers to ensure clean popup state between tests.Changes Made:
lib/helper/Playwright.js
: Added popup state clearing in_after()
method (3 lines added)lib/helper/Puppeteer.js
: Added popup state clearing in_after()
method (3 lines added)The fix is minimal, surgical, and preserves all existing functionality while preventing popup state leakage between tests.
Fixes #4971.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.