-
Notifications
You must be signed in to change notification settings - Fork 29
Migrate some django_apps to shared
#1089
Conversation
|
This PR includes changes to |
|
✅ All tests successful. No failed tests were found. 📣 Thoughts on this report? Let Codecov know! | Powered by Codecov |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #1089 +/- ##
==========================================
- Coverage 96.02% 95.99% -0.04%
==========================================
Files 831 831
Lines 19563 19407 -156
==========================================
- Hits 18785 18629 -156
Misses 778 778
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
codecov/shared#469 (review), as long as they seem good then I'm 👌
This effects the following: `compare`, `labelanalysis`, `profiling` and `staticanalysis` The models and factories are re-exported from `shared`, and the `MIGRATION_MODULES` is properly set up so that the migrations are being imported and ran from `shared`, and the local migrations are thus being removed.
a969c66 to
4f1d28e
Compare
|
This PR includes changes to |
This effects the following:
compare,labelanalysis,profilingandstaticanalysisThe models and factories are re-exported from
shared, and theMIGRATION_MODULESis properly set up so that the migrations are being imported and ran fromshared, and the local migrations are thus being removed.This depends on codecov/shared#469