Skip to content
This repository was archived by the owner on Jun 13, 2025. It is now read-only.

[draft] Push None attrs towards end of list in sorts #1109

Closed
wants to merge 1 commit into from
Closed

[draft] Push None attrs towards end of list in sorts #1109

wants to merge 1 commit into from

Conversation

@rohitvinnakota-codecov
Copy link
Contributor

@rohitvinnakota-codecov rohitvinnakota-codecov commented Jan 28, 2025

Purpose/Motivation

What is the feature? Why is this being done?

Links to relevant tickets

What does this PR do?

Include a brief description of the changes in this PR. Bullet points are your friend.

Notes to Reviewer

Anything to note to the team? Any tips on how to review, or where to start?

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov-notifications
Copy link

codecov-notifications bot commented Jan 28, 2025 •
edited by codecov-staging bot
Loading

❌ 25 Tests Failed:

Tests completed Failed Passed Skipped
2710 25 2685 7
View the top 3 failed tests by shortest run time 
graphql_api/tests/test_owner.py::TestOwnerType::test_is_part_of_org_when_unauthenticated
Stack Traces | 0.421s run time 
self = <graphql_api.tests.test_owner.TestOwnerType testMethod=test_is_part_of_org_when_unauthenticated>

    def test_is_part_of_org_when_unauthenticated(self):
        query = query_repositories % (self.owner.username, "", "")
        data = self.gql_request(query)
>       assert data["owner"]["isCurrentUserPartOfOrg"] is False
E       TypeError: 'NoneType' object is not subscriptable

graphql_api/tests/test_owner.py:282: TypeError
graphql_api/tests/test_owner.py::TestOwnerType::test_fetching_public_repository_when_unauthenticated
Stack Traces | 0.433s run time 
self = <graphql_api.tests.test_owner.TestOwnerType testMethod=test_fetching_public_repository_when_unauthenticated>

    def test_fetching_public_repository_when_unauthenticated(self):
        query = query_repositories % (self.owner.username, "", "")
        data = self.gql_request(query)
>       repos = paginate_connection(data["owner"]["repositories"])
E       TypeError: 'NoneType' object is not subscriptable

graphql_api/tests/test_owner.py:192: TypeError
graphql_api/tests/test_owner.py::TestOwnerType::test_fetching_active_repositories
Stack Traces | 0.435s run time 
self = <graphql_api.tests.test_owner.TestOwnerType testMethod=test_fetching_active_repositories>

    def test_fetching_active_repositories(self):
        query = query_repositories % (
            self.owner.username,
            "(filters: { active: true })",
            "",
        )
        data = self.gql_request(
            query, owner=self.owner, okta_signed_in_accounts=[self.account.id]
        )
>       repos = paginate_connection(data["owner"]["repositories"])
E       TypeError: 'NoneType' object is not subscriptable

graphql_api/tests/test_owner.py:174: TypeError

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@codecov-qa
Copy link

codecov-qa bot commented Jan 28, 2025 •
edited
Loading

❌ 25 Tests Failed:

Tests completed Failed Passed Skipped
2710 25 2685 7
View the top 3 failed tests by shortest run time 
graphql_api/tests/test_owner.py::TestOwnerType::test_is_part_of_org_when_unauthenticated
Stack Traces | 0.421s run time 
self = <graphql_api.tests.test_owner.TestOwnerType testMethod=test_is_part_of_org_when_unauthenticated>

    def test_is_part_of_org_when_unauthenticated(self):
        query = query_repositories % (self.owner.username, "", "")
        data = self.gql_request(query)
>       assert data["owner"]["isCurrentUserPartOfOrg"] is False
E       TypeError: 'NoneType' object is not subscriptable

graphql_api/tests/test_owner.py:282: TypeError
graphql_api/tests/test_owner.py::TestOwnerType::test_fetching_public_repository_when_unauthenticated
Stack Traces | 0.433s run time 
self = <graphql_api.tests.test_owner.TestOwnerType testMethod=test_fetching_public_repository_when_unauthenticated>

    def test_fetching_public_repository_when_unauthenticated(self):
        query = query_repositories % (self.owner.username, "", "")
        data = self.gql_request(query)
>       repos = paginate_connection(data["owner"]["repositories"])
E       TypeError: 'NoneType' object is not subscriptable

graphql_api/tests/test_owner.py:192: TypeError
graphql_api/tests/test_owner.py::TestOwnerType::test_fetching_active_repositories
Stack Traces | 0.435s run time 
self = <graphql_api.tests.test_owner.TestOwnerType testMethod=test_fetching_active_repositories>

    def test_fetching_active_repositories(self):
        query = query_repositories % (
            self.owner.username,
            "(filters: { active: true })",
            "",
        )
        data = self.gql_request(
            query, owner=self.owner, okta_signed_in_accounts=[self.account.id]
        )
>       repos = paginate_connection(data["owner"]["repositories"])
E       TypeError: 'NoneType' object is not subscriptable

graphql_api/tests/test_owner.py:174: TypeError

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@codecov-public-qa
Copy link

codecov-public-qa bot commented Jan 28, 2025 •
edited
Loading

❌ 25 Tests Failed:

Tests completed Failed Passed Skipped
2711 25 2686 6
View the top 3 failed tests by shortest run time 
graphql_api/tests/test_owner.py::TestOwnerType::test_is_part_of_org_when_unauthenticated
Stack Traces | 0.421s run time 
self = <graphql_api.tests.test_owner.TestOwnerType testMethod=test_is_part_of_org_when_unauthenticated>

    def test_is_part_of_org_when_unauthenticated(self):
        query = query_repositories % (self.owner.username, "", "")
        data = self.gql_request(query)
>       assert data["owner"]["isCurrentUserPartOfOrg"] is False
E       TypeError: 'NoneType' object is not subscriptable

graphql_api/tests/test_owner.py:282: TypeError
graphql_api/tests/test_owner.py::TestOwnerType::test_fetching_public_repository_when_unauthenticated
Stack Traces | 0.433s run time 
self = <graphql_api.tests.test_owner.TestOwnerType testMethod=test_fetching_public_repository_when_unauthenticated>

    def test_fetching_public_repository_when_unauthenticated(self):
        query = query_repositories % (self.owner.username, "", "")
        data = self.gql_request(query)
>       repos = paginate_connection(data["owner"]["repositories"])
E       TypeError: 'NoneType' object is not subscriptable

graphql_api/tests/test_owner.py:192: TypeError
graphql_api/tests/test_owner.py::TestOwnerType::test_fetching_active_repositories
Stack Traces | 0.435s run time 
self = <graphql_api.tests.test_owner.TestOwnerType testMethod=test_fetching_active_repositories>

    def test_fetching_active_repositories(self):
        query = query_repositories % (
            self.owner.username,
            "(filters: { active: true })",
            "",
        )
        data = self.gql_request(
            query, owner=self.owner, okta_signed_in_accounts=[self.account.id]
        )
>       repos = paginate_connection(data["owner"]["repositories"])
E       TypeError: 'NoneType' object is not subscriptable

graphql_api/tests/test_owner.py:174: TypeError

To view more test analytics, go to the Test Analytics Dashboard
📢 Thoughts on this report? Let us know!

@github-actions
Copy link
Contributor

github-actions bot commented Jan 28, 2025 •
edited
Loading

❌ 25 Tests Failed:

Tests completed Failed Passed Skipped
2717 25 2686 6
View the top 3 failed tests by shortest run time 
test_fetching_public_repository_when_unauthenticated
Stack Traces | 0.414s run time 
self = &lt;graphql_api.tests.test_owner.TestOwnerType testMethod=test_fetching_public_repository_when_unauthenticated&gt;

    def test_fetching_public_repository_when_unauthenticated(self):
        query = query_repositories % (self.owner.username, "", "")
        data = self.gql_request(query)
&gt;       repos = paginate_connection(data["owner"]["repositories"])
E       TypeError: 'NoneType' object is not subscriptable

graphql_api/tests/test_owner.py:192: TypeError

test_is_part_of_org_when_unauthenticated
Stack Traces | 0.416s run time 
self = &lt;graphql_api.tests.test_owner.TestOwnerType testMethod=test_is_part_of_org_when_unauthenticated&gt;

    def test_is_part_of_org_when_unauthenticated(self):
        query = query_repositories % (self.owner.username, "", "")
        data = self.gql_request(query)
&gt;       assert data["owner"]["isCurrentUserPartOfOrg"] is False
E       TypeError: 'NoneType' object is not subscriptable

graphql_api/tests/test_owner.py:282: TypeError

test_fetching_repositories_active_repositories
Stack Traces | 0.425s run time 
self = &lt;graphql_api.tests.test_owner.TestOwnerType testMethod=test_fetching_repositories_active_repositories&gt;

    def test_fetching_repositories_active_repositories(self):
        query = query_repositories % (
            self.owner.username,
            "(filters: { active: true })",
            "",
        )
        data = self.gql_request(
            query, owner=self.owner, okta_signed_in_accounts=[self.account.id]
        )
&gt;       repos = paginate_connection(data["owner"]["repositories"])
E       TypeError: 'NoneType' object is not subscriptable

graphql_api/tests/test_owner.py:238: TypeError

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

@rohitvinnakota-codecov rohitvinnakota-codecov force-pushed the rvinnakota/none-at-end-ordering branch from e3a7229 to 36004a5 Compare January 28, 2025 21:00
@rohitvinnakota-codecov rohitvinnakota-codecov force-pushed the rvinnakota/none-at-end-ordering branch from 36004a5 to 9c7adc2 Compare January 28, 2025 21:24
@rohitvinnakota-codecov rohitvinnakota-codecov marked this pull request as ready for review January 29, 2025 15:56
@rohitvinnakota-codecov rohitvinnakota-codecov requested a review from a team as a code owner January 29, 2025 15:56
@rohitvinnakota-codecov
Copy link
Contributor Author

rohitvinnakota-codecov commented Jan 29, 2025

@codecov-ai-reviewer review2

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@rohitvinnakota-codecov