-
Notifications
You must be signed in to change notification settings - Fork 29
Optimize usage of match
#1142
Optimize usage of match
#1142
Conversation
|
This PR includes changes to |
|
Is codecov-api/api/public/v2/report/views.py Lines 111 to 113 in e72e553
|
|
In theory, yes. But that code is not being run in a loop, so would not benefit from a stateful matcher. |
3964169 to
dd0f85d
Compare
|
This PR includes changes to |
|
@Swatinem Got it, I thought your shared PR removed the stateless match() fn but saw it was just at the bottom of the file, lgtm |
This creates stateful `Matcher`s instead, to avoid re-compiling regex matchers in loops.
dd0f85d to
f8789d6
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #1142 +/- ##
=======================================
Coverage 96.07% 96.07%
=======================================
Files 838 838
Lines 19773 19775 +2
=======================================
+ Hits 18996 18998 +2
Misses 777 777
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
✅ All tests successful. No failed tests were found. 📣 Thoughts on this report? Let Codecov know! | Powered by Codecov |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
This creates stateful
Matchers instead, to avoid re-compiling regex matchers in loops.Builds on top of #1141, depends on codecov/shared#502