-
Notifications
You must be signed in to change notification settings - Fork 29
fix: Account for Multiple Owners being returned when handling stripe payment intent webhook #1146
Conversation
🔍 Existing Issues For ReviewYour pull request is modifying functions with the following pre-existing issues: 📄 File: billing/views.py
Did you find this useful? React with a 👍 or 👎 |
|
✅ All tests successful. No failed tests were found. 📣 Thoughts on this report? Let Codecov know! | Powered by Codecov |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
suejung-sentry
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for fixing that!
| owner.stripe_subscription_id, default_payment_method=payment_method | ||
| # retrieve the number of owners to update | ||
| owners = Owner.objects.filter( | ||
| stripe_customer_id=customer_id, stripe_subscription_id__isnull=False |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice, i like adding the filter for not null
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #1146 +/- ##
=======================================
Coverage 96.02% 96.02%
=======================================
Files 837 837
Lines 19763 19766 +3
=======================================
+ Hits 18978 18981 +3
Misses 785 785
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Purpose/Motivation
This PR aims to fix a Sentry issue that popped up after we launched ACH related to a customer trying to update their payment method while having multiple stripe subscription_ids tied to the customer_id in our DB. I noticed that for this customer both of the subscription_ids were the same, but wanted the code to accommodate cases where that wasn't necessarily the case; potentially someone who wants to spread Codecov across the many orgs their apart of ;)
Links to relevant tickets
Closes codecov/engineering-team#3323
Notes to Reviewer
Anything to note to the team? Any tips on how to review, or where to start?
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.