Skip to content
This repository was archived by the owner on Jun 13, 2025. It is now read-only.

Conversation

@giovanni-guidini
Copy link
Contributor

This new action triggers the "sync_repos" for the selected owner from the admin dashboard. Would have been helpful for me today.

(only tested through the unit tests)

@seer-by-sentry
Copy link
Contributor

seer-by-sentry bot commented Apr 23, 2025

🚨 Sentry detected 2 potential issues in your recent changes 🚨

Lower risk findings

Did you find this useful? React with a 👍 or 👎

This new action triggers the "sync_repos" for the selected owner from the admin dashboard.
Would have been helpful for me today.

(only tested through the unit tests)
@giovanni-guidini giovanni-guidini force-pushed the gio/sync-repos-from-admin branch from fd3b3d2 to 06d3fe1 Compare April 24, 2025 08:51
@codecov-notifications
Copy link

codecov-notifications bot commented Apr 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@codecov
Copy link

codecov bot commented Apr 24, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.30%. Comparing base (18eb985) to head (06d3fe1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1295   +/-   ##
=======================================
  Coverage   96.29%   96.30%           
=======================================
  Files         488      488           
  Lines       16995    17007   +12     
=======================================
+ Hits        16366    16378   +12     
  Misses        629      629           
Flag Coverage Δ
unit 96.30% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@giovanni-guidini giovanni-guidini requested a review from a team April 24, 2025 09:23
level=messages.SUCCESS,
)
History.log(
Owner.objects.get(ownerid=owner.ownerid),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this would just be owner, right?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I wasn't sure, cause there is an OwnerAdmin class (line 593) so I wasn't sure if the queryset is of OwnerAdmins or Owners :E

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SO I copied what impersonate_owner does :P

def refresh_owner(self, request, queryset):
if queryset.count() != 1:
self.message_user(
request, "You must refresh exactly one Owner.", level=messages.ERROR
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it should be trivially possible to also support multiple-select.

@giovanni-guidini giovanni-guidini added this pull request to the merge queue Apr 24, 2025
Merged via the queue into main with commit 8c6853a Apr 24, 2025
23 of 25 checks passed
@giovanni-guidini giovanni-guidini deleted the gio/sync-repos-from-admin branch April 24, 2025 10:52
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants