Skip to content
This repository was archived by the owner on Jun 13, 2025. It is now read-only.

Conversation

@joseph-sentry
Copy link
Contributor

No description provided.

@joseph-sentry joseph-sentry requested a review from a team as a code owner October 11, 2024 17:29
@codecov-notifications
Copy link

codecov-notifications bot commented Oct 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@codecov
Copy link

codecov bot commented Oct 11, 2024

Codecov Report

Attention: Patch coverage is 94.85294% with 7 lines in your changes missing coverage. Please review.

Project coverage is 96.28%. Comparing base (3ee723e) to head (96322b0).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
utils/test_results.py 93.39% 7 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #883      +/-   ##
==========================================
- Coverage   96.31%   96.28%   -0.04%     
==========================================
  Files         823      823              
  Lines       19077    19150      +73     
==========================================
+ Hits        18374    18438      +64     
- Misses        703      712       +9     
Flag Coverage Δ
unit 92.63% <94.85%> (-0.03%) ⬇️
unit-latest-uploader 92.63% <94.85%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@joseph-sentry joseph-sentry force-pushed the joseph/add-testsuites-flags branch from 96322b0 to ca2cd18 Compare October 18, 2024 21:05
"flakeRatePercentChange": -43.75,
}

def test_test_suites(self) -> None:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can we add 2 more tests where there's no filter? To hit the elses

Copy link
Contributor

@ajay-sentry ajay-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

@joseph-sentry joseph-sentry added this pull request to the merge queue Oct 18, 2024
Merged via the queue into main with commit e14d14d Oct 18, 2024
18 of 19 checks passed
@joseph-sentry joseph-sentry deleted the joseph/add-testsuites-flags branch October 18, 2024 22:10
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants