-
Notifications
You must be signed in to change notification settings - Fork 29
feat: Clean up old graphql commit fields #898
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #898 +/- ##
==========================================
- Coverage 96.26% 96.25% -0.01%
==========================================
Files 823 823
Lines 19048 18999 -49
==========================================
- Hits 18337 18288 -49
Misses 711 711
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
❌ 33 Tests Failed:
View the top 3 failed tests by shortest run time
To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard |
|
Test Failures Detected: Due to failing tests, we cannot provide coverage reports at this time. ❌ Failed Test Results:Completed 2709 tests with View the full list of failed testspytest
|
79aa973 to
a878c07
Compare
suejung-sentry
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like there are some conflicts with main & some tests failing.
How did the test sweep against gazebo main go? If you have some screenshots on those we can add it to this PR for posterity.
Otherwise the changes make sense to me!
a878c07 to
3af970a
Compare
acf46a2 to
5ac92d0
Compare
5ac92d0 to
19dc91b
Compare
Purpose/Motivation
What is the feature? Why is this being done?
Cleanup the graphql changes made at #847 as the fields should now be switched onto the new structure.
Links to relevant tickets
Closes codecov/engineering-team#2286
What does this PR do?
Include a brief description of the changes in this PR. Bullet points are your friend.
Notes to Reviewer
Anything to note to the team? Any tips on how to review, or where to start?