This repository was archived by the owner on Jun 13, 2025. It is now read-only.
chore: Remove GQL playground access from prod #936
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #936 +/- ##
=======================================
Coverage 96.23% 96.23%
=======================================
Files 823 823
Lines 18972 18972
=======================================
Hits 18257 18257
Misses 715 715
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
calvin-codecov
force-pushed
the
cy/no_prod_gql_playground
branch
from
cc9366c to
d9fb01b
Compare
ajay-sentry
approved these changes
Oct 29, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose/Motivation
What is the feature? Why is this being done?
Closes https://github.com/codecov/internal-issues/issues/916
Turning the setting off for
SettingsModule.PRODUCTION.valueandSettingsModule.ENTERPRISE.valueTested locally by setting the line to
get_settings_module() != SettingsModule.DEV.valueand tried accessing at http://localhost:8000/graphql/ and the page was inaccessible.