This repository was archived by the owner on Jun 13, 2025. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 29
Add bank account class #937
Closed
Closed
Changes from all commits
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,30 @@ | ||
| class BankAccount: | ||
| def __init__(self, owner, balance=0.0): | ||
| self.owner = owner | ||
| if balance < 0: | ||
| raise ValueError("Initial balance cannot be negative") | ||
| self.balance = balance | ||
|
|
||
| def deposit(self, amount): | ||
| if amount <= 0: | ||
| raise ValueError("Deposit amount must be positive") | ||
| self.balance += amount | ||
| return self.balance | ||
|
|
||
| def withdraw(self, amount): | ||
| if amount <= 0: | ||
| raise ValueError("Withdrawal amount must be positive") | ||
| if amount > self.balance: | ||
| raise ValueError("Insufficient funds") | ||
| self.balance -= amount | ||
| return self.balance | ||
|
|
||
| def transfer(self, other_account, amount): | ||
| if not isinstance(other_account, BankAccount): | ||
| raise ValueError("Recipient must be a BankAccount instance") | ||
| self.withdraw(amount) | ||
| other_account.deposit(amount) | ||
| return self.balance, other_account.balance | ||
|
|
||
| def get_balance(self): | ||
| return self.balance | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The
transfermethod should handle the case where the transfer fails due to insufficient funds or other reasons. Currently, ifself.withdraw(amount)raises an exception, theother_account.deposit(amount)will not be executed, but the exception will not be caught or handled.