Skip to content
This repository was archived by the owner on Jun 13, 2025. It is now read-only.

Conversation

@ajay-sentry
Copy link
Contributor

Purpose/Motivation

Bumps shared to latest commit

Includes codecov/shared@cc72dcb

Notes to Reviewer

Anything to note to the team? Any tips on how to review, or where to start?

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@github-actions
Copy link
Contributor

This PR includes changes to shared. Please review them here: codecov/shared@83b3376...cc72dcb

@codecov-staging
Copy link

codecov-staging bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@codecov
Copy link

codecov bot commented Oct 31, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.24%. Comparing base (8fa8e1c) to head (e44e635).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #951   +/-   ##
=======================================
  Coverage   96.24%   96.24%           
=======================================
  Files         826      826           
  Lines       19016    19016           
=======================================
  Hits        18302    18302           
  Misses        714      714           
Flag Coverage Δ
unit 92.49% <ø> (ø)
unit-latest-uploader 92.49% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-qa
Copy link

codecov-qa bot commented Oct 31, 2024

❌ 1 Tests Failed:

Tests completed Failed Passed Skipped
2648 1 2647 6
View the top 1 failed tests by shortest run time
upload/tests/test_serializers.py::test_upload_serializer_contains_expected_fields_with_flags
Stack Traces | 0.364s run time
transactional_db = None
mocker = &lt;pytest_mock.plugin.MockerFixture object at 0x7fdee67062a0&gt;

    def test_upload_serializer_contains_expected_fields_with_flags(
        transactional_db, mocker
    ):
        mocker.patch(
            "services.archive.StorageService.create_presigned_put",
            return_value="presigned put",
        )
        upload = get_fake_upload_with_flags()
        serializer = UploadSerializer(instance=upload)
        repo = upload.report.commit.repository
        expected_data = {
            "external_id": str(upload.external_id),
            "created_at": upload.created_at.strftime("%Y-%m-%dT%H:%M:%S.%fZ"),
            "raw_upload_location": "presigned put",
            "state": upload.state,
            "provider": upload.provider,
            "upload_type": upload.upload_type,
            "ci_url": upload.build_url,
            "flags": ["flag1", "flag2"],
            "job_code": upload.job_code,
            "env": upload.env,
            "name": upload.name,
            "url": f"{settings.CODECOV_DASHBOARD_URL}/{repo.author.service}/{repo.author.username}/{repo.name}/commit/{upload.report.commit.commitid}",
        }
&gt;       assert serializer.data == expected_data
E       AssertionError: assert {'external_id...b_code': None} == {'ci_url': No...9595e6b', ...}
E         
E         Omitting 11 identical items, use -vv to show
E         Differing items:
E         {'flags': ['flag2', 'flag1']} != {'flags': ['flag1', 'flag2']}
E         Use -v to get more diff

upload/tests/test_serializers.py:112: AssertionError

To view individual test run time comparison to the main branch, go to the Test Analytics Dashboard

@codecov-public-qa
Copy link

Test Failures Detected: Due to failing tests, we cannot provide coverage reports at this time.

❌ Failed Test Results:

Completed 2654 tests with 1 failed, 2647 passed and 6 skipped.

View the full list of failed tests

pytest

  • Class name: upload.tests.test_serializers
    Test name: test_upload_serializer_contains_expected_fields_with_flags

    transactional_db = None
    mocker = <pytest_mock.plugin.MockerFixture object at 0x7fdee67062a0>

    def test_upload_serializer_contains_expected_fields_with_flags(
    transactional_db, mocker
    ):
    mocker.patch(
    "services.archive.StorageService.create_presigned_put",
    return_value="presigned put",
    )
    upload = get_fake_upload_with_flags()
    serializer = UploadSerializer(instance=upload)
    repo = upload.report.commit.repository
    expected_data = {
    "external_id": str(upload.external_id),
    "created_at": upload.created_at.strftime("%Y-%m-%dT%H:%M:%S.%fZ"),
    "raw_upload_location": "presigned put",
    "state": upload.state,
    "provider": upload.provider,
    "upload_type": upload.upload_type,
    "ci_url": upload.build_url,
    "flags": ["flag1", "flag2"],
    "job_code": upload.job_code,
    "env": upload.env,
    "name": upload.name,
    "url": f"{settings.CODECOV_DASHBOARD_URL}/{repo.author.service}/{repo.author.username}/{repo.name}/commit/{upload.report.commit.commitid}",
    }
    > assert serializer.data == expected_data
    E AssertionError: assert {'external_id...b_code': None} == {'ci_url': No...9595e6b', ...}
    E
    E Omitting 11 identical items, use -vv to show
    E Differing items:
    E {'flags': ['flag2', 'flag1']} != {'flags': ['flag1', 'flag2']}
    E Use -v to get more diff

    upload/tests/test_serializers.py:112: AssertionError

@ajay-sentry ajay-sentry added this pull request to the merge queue Nov 1, 2024
Merged via the queue into main with commit 564cad4 Nov 1, 2024
20 checks passed
@ajay-sentry ajay-sentry deleted the Ajay/bump-s-l branch November 1, 2024 15:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants