Skip to content
This repository was archived by the owner on Jun 13, 2025. It is now read-only.

add true tokenless to all upload endpoints, remove from TR #958

Merged
merged 1 commit into from
Nov 6, 2024
+4 −2
Merged

add true tokenless to all upload endpoints, remove from TR #958

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions upload/views/empty_upload.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@
GlobalTokenAuthentication,
OrgLevelTokenAuthentication,
RepositoryLegacyTokenAuthentication,
UploadTokenRequiredAuthenticationCheck,
repo_auth_custom_exception_handler,
)
from codecov_auth.authentication.types import RepositoryAsUser
Expand Down Expand Up @@ -73,6 +74,7 @@ class EmptyUploadSerializer(serializers.Serializer):
class EmptyUploadView(CreateAPIView, GetterMixin):
permission_classes = [CanDoCoverageUploadsPermission]
authentication_classes = [
UploadTokenRequiredAuthenticationCheck,
GlobalTokenAuthentication,
OrgLevelTokenAuthentication,
GitHubOIDCTokenAuthentication,
Expand Down
2 changes: 0 additions & 2 deletions upload/views/test_results.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,6 @@
OrgLevelTokenAuthentication,
RepositoryLegacyTokenAuthentication,
TokenlessAuthentication,
UploadTokenRequiredAuthenticationCheck,
repo_auth_custom_exception_handler,
)
from codecov_auth.authentication.types import RepositoryAsUser
Expand Down Expand Up @@ -59,7 +58,6 @@ class TestResultsView(
):
permission_classes = [UploadTestResultsPermission]
authentication_classes = [
UploadTokenRequiredAuthenticationCheck,
Copy link
Member Author

@nora-shap nora-shap Nov 4, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TR needs a custom method, this is in an upcoming pr. We can leave this auth method in the stack, but it would never evaluate to True.

OrgLevelTokenAuthentication,
GitHubOIDCTokenAuthentication,
RepositoryLegacyTokenAuthentication,
Expand Down
2 changes: 2 additions & 0 deletions upload/views/upload_completion.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
GlobalTokenAuthentication,
OrgLevelTokenAuthentication,
RepositoryLegacyTokenAuthentication,
UploadTokenRequiredAuthenticationCheck,
repo_auth_custom_exception_handler,
)
from reports.models import ReportSession
Expand All @@ -25,6 +26,7 @@
class UploadCompletionView(CreateAPIView, GetterMixin):
permission_classes = [CanDoCoverageUploadsPermission]
authentication_classes = [
UploadTokenRequiredAuthenticationCheck,
GlobalTokenAuthentication,
OrgLevelTokenAuthentication,
GitHubOIDCTokenAuthentication,
Expand Down
Loading