Skip to content
This repository was archived by the owner on Jun 13, 2025. It is now read-only.

chore: Add async linting #968

Merged
merged 6 commits into from
Nov 12, 2024
Merged

chore: Add async linting #968

Changes from 5 commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
39aba43
feat: Add async linting
suejung-sentry Nov 7, 2024
d377eff
experiments
suejung-sentry Nov 11, 2024
ea19cfe
cleanup
suejung-sentry Nov 11, 2024
c87bcb6
alphabetize
suejung-sentry Nov 12, 2024
e69547c
Merge remote-tracking branch 'origin/main' into sshin/fix/lint
suejung-sentry Nov 12, 2024
b8d4986
fix comment
suejung-sentry Nov 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 10 additions & 3 deletions ruff.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,16 @@ indent-width = 4
target-version = "py312"

[lint]
# Currently only enabled for F (Pyflakes), I (isort), E,W (pycodestyle:Error/Warning), PLC/PLE (Pylint:Convention/Error)
# and PERF (Perflint) rules: https://docs.astral.sh/ruff/rules/
select = ["F", "I", "E", "W", "PLC", "PLE", "PERF"]
select = [
"ASYNC", # flake8-async - async checks
"E", # pycodestyle - error rules
"F", # pyflakes - general Python errors, undefined names
"I", # isort - import sorting
"PERF", # perflint - https://docs.astral.sh/ruff/rules/
Copy link
Contributor

@ajay-sentry ajay-sentry Nov 12, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: maybe this should be "performance anti-pattern rules" and the rules link should be above

Copy link
Contributor Author

@suejung-sentry suejung-sentry Nov 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

oh woops, I misread what the original comment was trying to convey haha. Fixed!

Copy link
Contributor

@ajay-sentry ajay-sentry Nov 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

haha no worries

"PLC", # pylint - convention rules
"PLE", # pylint - error rules
"W", # pycodestyle - warning rules
]
ignore = ["F405", "F403", "E501", "E712"]

# Allow fix for all enabled rules (when `--fix`) is provided.
Expand Down
Loading