Conversation
spalmurray
commented
Jul 3, 2025
| env: | ||
| SENTRY_AUTH_TOKEN: ${{ secrets.SENTRY_AUTH_TOKEN }} | ||
| VERSION: ${{ github.event.release.tag_name }} | ||
| - name: Prepare Firefox extension |
Contributor
Author
There was a problem hiding this comment.
key thing is we need to use the build:firefox script instead of this manual move. Reason being the builds are actually different now with the IS_FIREFOX env var
Contributor
There was a problem hiding this comment.
Ah right of course, good find!
ElioDiNino
previously approved these changes
Jul 3, 2025
Contributor
ElioDiNino
left a comment
ElioDiNino
left a comment
There was a problem hiding this comment.
Looks good. Now that it goes from build Chrome -> build Firefox -> publish both to build -> publish -> build -> publish we could consider splitting the Firefox and Chrome flows into separate jobs, but this is by no means required.
| env: | ||
| SENTRY_AUTH_TOKEN: ${{ secrets.SENTRY_AUTH_TOKEN }} | ||
| VERSION: ${{ github.event.release.tag_name }} | ||
| - name: Prepare Firefox extension |
Contributor
There was a problem hiding this comment.
Ah right of course, good find!
ElioDiNino
approved these changes
Jul 3, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes the publish workflow for reproducible firefox builds.