Skip to content

Conversation

@github-actions
Copy link
Contributor

This PR was opened by the Changesets release GitHub action. When you're ready to do a release, you can merge this and publish to npm yourself or setup this action to publish automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated.

Releases

@codecov/[email protected]

Minor Changes

  • 6c4377d: Add in better debug logging when fetching pre-signed url or uploading stats fail. Update current logs to have more details present.

Patch Changes

@codecov/[email protected]

Minor Changes

  • 6c4377d: Add in better debug logging when fetching pre-signed url or uploading stats fail. Update current logs to have more details present.

@codecov/[email protected]

Minor Changes

  • 6c4377d: Add in better debug logging when fetching pre-signed url or uploading stats fail. Update current logs to have more details present.

Patch Changes

@codecov/[email protected]

Minor Changes

  • 6c4377d: Add in better debug logging when fetching pre-signed url or uploading stats fail. Update current logs to have more details present.

Patch Changes

@codecov/[email protected]

Minor Changes

  • 6c4377d: Add in better debug logging when fetching pre-signed url or uploading stats fail. Update current logs to have more details present.

Patch Changes

@codecov/[email protected]

Minor Changes

  • 6c4377d: Add in better debug logging when fetching pre-signed url or uploading stats fail. Update current logs to have more details present.

Patch Changes

@codecov/[email protected]

Minor Changes

  • 6c4377d: Add in better debug logging when fetching pre-signed url or uploading stats fail. Update current logs to have more details present.

Patch Changes

@codecov/[email protected]

Minor Changes

  • 6c4377d: Add in better debug logging when fetching pre-signed url or uploading stats fail. Update current logs to have more details present.

Patch Changes

@codecov/[email protected]

Minor Changes

  • 6c4377d: Add in better debug logging when fetching pre-signed url or uploading stats fail. Update current logs to have more details present.

Patch Changes

@codecov/[email protected]

Minor Changes

  • 6c4377d: Add in better debug logging when fetching pre-signed url or uploading stats fail. Update current logs to have more details present.

Patch Changes

Copy link

@codecov codecov bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The commit seems to be all about version bump and logging improvemnets across different packages in the repository. The new versions for the packages are set correctly in the package.json and the changelog is updated for all the respective packages. The commit can be approved as the logging improvements do not look to affect any functional part of the code.


### Minor Changes

- 6c4377d: Add in better debug logging when fetching pre-signed url or uploading stats fail. Update current logs to have more details present.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make sure to test the changes in a staging environment or add some unit tests for the logging improvements.

### Patch Changes

- Updated dependencies [6c4377d]
- @codecov/bundler-plugin-core@1.2.0
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's good to see that dependencies are updated with the version bump.

{
"name": "@codecov/bundle-analyzer",
"version": "1.1.0",
"version": "1.2.0",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The version bump here seems to follow the semantic versioning correctly.


### Minor Changes

- 6c4377d: Add in better debug logging when fetching pre-signed url or uploading stats fail. Update current logs to have more details present.
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As this is a minor version update, please make sure that these changes will not cause any breaking changes.

- @codecov/bundler-plugin-core@1.2.0
- @codecov/vite-plugin@1.2.0

## 1.1.0
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Effective use of a changelog. It will be helpful to see when and what changes were introduced in each update.

@@ -1,6 +1,6 @@
{
"name": "@codecov/solidstart-plugin",
"version": "1.1.0",
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please ensure that the updated version number is also reflected in any documentation or 'ReadMe' files that may reference these package versions.

### Minor Changes

- 6c4377d: Add in better debug logging when fetching pre-signed url or uploading stats fail. Update current logs to have more details present.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see dependencies also up to date. It would prevent potential out-of-sync issues.


- 6c4377d: Add in better debug logging when fetching pre-signed url or uploading stats fail. Update current logs to have more details present.

### Patch Changes
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When updating the changelog, it would be helpful to add a bit more context about the improvements to the debug logging to inform users.

Copy link
Contributor

@suejung-sentry suejung-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approved! do we need to update all the version numbers in the integration tests too?

@codecov-notifications
Copy link

codecov-notifications bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Components Coverage Δ
Plugin core 96.70% <ø> (ø)
Rollup plugin 10.81% <ø> (ø)
Vite plugin 11.02% <ø> (ø)
Webpack plugin 49.88% <ø> (ø)

📢 Thoughts on this report? Let us know!

@codecov
Copy link

codecov bot commented Sep 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 77.01%. Comparing base (6c4377d) to head (71086fd).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
Components Coverage Δ
Plugin core 96.70% <ø> (ø)
Rollup plugin 10.81% <ø> (ø)
Vite plugin 11.02% <ø> (ø)
Webpack plugin 49.88% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-staging
Copy link

Bundle Report

Bundle size has no change ✅

Bundle name Size Change
@codecov/example-next-app-edge-server-array-push 354 bytes 0 bytes
@codecov/example-next-15-app-edge-server-array-push 356 bytes 0 bytes

@codecov
Copy link

codecov bot commented Sep 20, 2024

Bundle Report

Changes will increase total bundle size by 3 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
@codecov/example-sveltekit-app-client-esm 714.98kB 2 bytes (0.0%) ⬆️
@codecov/example-sveltekit-app-server-esm 974.85kB 1 bytes (0.0%) ⬆️

@nicholas-codecov nicholas-codecov merged commit 948da4a into main Sep 20, 2024
@nicholas-codecov nicholas-codecov deleted the changeset-release/main branch September 20, 2024 18:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants