chore: Add in debug logs for all upload params #179
Conversation
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
📢 Thoughts on this report? Let us know! |
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files
☔ View full report in Codecov by Sentry. |
spalmurray-codecov
left a comment
spalmurray-codecov
left a comment
There was a problem hiding this comment.
Did a quick skim, seems good.
Bundle ReportChanges will increase total bundle size by 2.6MB (365803.94%) ⬆️
|
Bundle ReportChanges will decrease total bundle size by 17.33kB (-0.3%) ⬇️. This is within the configured threshold ✅ Detailed changes
|
suejung-sentry
left a comment
suejung-sentry
left a comment
There was a problem hiding this comment.
looks good to me - thanks for doing this tedious work!
| uploadToken: process.env.BUNDLE_ANALYZER_UPLOAD_TOKEN, | ||
| retryCount: 3, | ||
| apiUrl: "https://api.codecov.io", | ||
| apiUrl: process.env.BUNDLE_ANALYZER_API_URL, |
There was a problem hiding this comment.
Nice, thanks for updating these! Agreed it's better to pull from env than hardcoding
| const { envs } = inputs; | ||
| return envs?.BITRISE_BUILD_URL ?? null; | ||
| const buildURL = envs?.BITRISE_BUILD_URL ?? null; | ||
| debug(`Using buildURL: ${buildURL}`, { enabled: output.debug }); |
There was a problem hiding this comment.
I did a little checking around if any of these buildURLs contain any ?token=abcd or sensitive info we shouldn't log - seems like we're good to go!
| return envs?.APPVEYOR_JOB_ID ?? null; | ||
|
|
||
| const build = envs?.APPVEYOR_BUILD_ID ?? null; | ||
| debug(`Using build: ${build}`, { enabled: output.debug }); |
There was a problem hiding this comment.
Probably not needed right now but devs that are debugging may find it helpful in the future if we log the source as well (as in from args or env).
| branch: _getBranch(inputs), | ||
| build: _getBuild(inputs), | ||
| buildURL: _getBuildURL(inputs), | ||
| branch: _getBranch(inputs, output), |
There was a problem hiding this comment.
I personally found the arg name output a bit confusing since if that is passed as an arg I'd wonder if that's something passed by reference expecting to get mutated.
Fine to leave as is since the pattern is already well-established across the rest of the code, just a passing musing
nicholas-codecov
deleted the
chore-add-in-debug-logs-for-all-upload-params
branch
Description
This PR adds debug logging to each provider on all the different getter functions so that we can provide a better debugging experience for users.
Notable Changes