Skip to content

remove constraint for True Tokenless #181

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

remove constraint for True Tokenless #181

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2725c9f
remove constraint for True Tokenless
nora-shap Oct 12, 2024
0a89a12
change logic around
nora-shap Oct 12, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/bundler-plugin-core/src/utils/getPreSignedURL.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -50,7 +50,7 @@ export const getPreSignedURL = async ({
* proper tokenless upload.
* See: https://github.com/codecov/codecov-api/pull/741
*/
if (!uploadToken && serviceParams.branch?.includes(":")) {
Copy link

@codecov codecov bot Oct 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Removing this condition means the format of the branch is no longer checked. Has the branch check been moved elsewhere, or is it no longer needed? If not necessary anymore, kindly disregard the comment.

if (!uploadToken) {
Copy link

@codecov codecov bot Oct 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This check now only verifies the existence of an 'uploadToken'. It will enter the if block even if there is no ':' in the 'branch'. Consider rechecking the requirements for 'uploadToken' and 'branch'.

if (gitService) {
Copy link

@codecov codecov bot Oct 12, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here you are setting 'gitService' if 'uploadToken' is not available. The control flow suggests that these two fields are somehow interchangeable or correlated. However, there might not be any correlation between 'uploadToken' and 'gitService', consider segregating the conditions or explain the logical correlation between them.

requestBody.git_service = gitService;
} else {
Expand Down
Loading