Skip to content

Conversation

@suejung-sentry
Copy link
Contributor

@suejung-sentry suejung-sentry commented Nov 14, 2024

Bump version of next to resolve vulnerabilities

  • 14.2.10
  • 13.5.7

Closes https://github.com/codecov/internal-issues/issues/929
Closes https://github.com/codecov/internal-issues/issues/935

Due 11/18/24

@codecov
Copy link

codecov bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.08%. Comparing base (2db57cc) to head (2efad06).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
Components Coverage Δ
Plugin core 97.06% <ø> (ø)
Rollup plugin 10.81% <ø> (ø)
Vite plugin 11.02% <ø> (ø)
Webpack plugin 49.88% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-notifications
Copy link

codecov-notifications bot commented Nov 14, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Components Coverage Δ
Plugin core 97.06% <ø> (ø)
Rollup plugin 10.81% <ø> (ø)
Vite plugin 11.02% <ø> (ø)
Webpack plugin 49.88% <ø> (ø)

📢 Thoughts on this report? Let us know!

@suejung-sentry suejung-sentry marked this pull request as ready for review November 14, 2024 01:26
@codecov-staging
Copy link

codecov-staging bot commented Nov 14, 2024

Bundle Report

Changes will decrease total bundle size by 40.82kB (-1.46%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
@codecov/example-next-app-edge-server-array-push 356 bytes 2 bytes (0.56%) ⬆️
@codecov/bundler-plugin-core-esm 12.29kB 40.83kB (-76.87%) ⬇️
@codecov/example-next-app-server-cjs 340.66kB 67 bytes (-0.02%) ⬇️
@codecov/example-next-app-client-array-push 687.13kB 73 bytes (0.01%) ⬆️

@codecov
Copy link

codecov bot commented Nov 14, 2024

Bundle Report

Changes will decrease total bundle size by 41.52kB (-0.72%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
@codecov/bundler-plugin-core-esm 12.29kB 40.83kB (-76.87%) ⬇️
@codecov/sveltekit-plugin-esm 1.09kB 198 bytes (22.22%) ⬆️
@codecov/webpack-plugin-esm 3.36kB 6 bytes (-0.18%) ⬇️
@codecov/example-next-app-edge-server-array-push 356 bytes 2 bytes (0.56%) ⬆️
@codecov/solidstart-plugin-esm 949 bytes 142 bytes (-13.02%) ⬇️
@codecov/example-sveltekit-app-client-esm 715.09kB 2 bytes (-0.0%) ⬇️
@codecov/example-next-app-server-cjs 340.66kB 67 bytes (-0.02%) ⬇️
@codecov/example-next-app-client-array-push 687.13kB 73 bytes (0.01%) ⬆️
@codecov/nextjs-webpack-plugin-esm 1.11kB 753 bytes (-40.33%) ⬇️

},
"peerDependencies": {
"next": "14.x || 15.x",
"next": ">=14.2.10 <16.0.0",

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@suejung-sentry are we able to rollback to the prior implementation of peer deps declarations?

With these changes, we'd have to move from a patch to a major release as we're requiring users to update their version of next. If they don't, peer dep resolution would fail while they try to install the plugin.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah yeah good point. I won't force that upon people & just fix in our examples / integration-tests instead to resolve the vulnerability - thanks!

@suejung-sentry suejung-sentry merged commit 6552110 into main Nov 15, 2024
62 checks passed
@suejung-sentry suejung-sentry deleted the sshin/chore/nextjs branch November 15, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants