-
Notifications
You must be signed in to change notification settings - Fork 6
chore: Resolve nextjs vuln #190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files
☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found.
📢 Thoughts on this report? Let us know! |
Bundle ReportChanges will decrease total bundle size by 40.82kB (-1.46%) ⬇️. This is within the configured threshold ✅ Detailed changes
|
Bundle ReportChanges will decrease total bundle size by 41.52kB (-0.72%) ⬇️. This is within the configured threshold ✅ Detailed changes
|
| }, | ||
| "peerDependencies": { | ||
| "next": "14.x || 15.x", | ||
| "next": ">=14.2.10 <16.0.0", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@suejung-sentry are we able to rollback to the prior implementation of peer deps declarations?
With these changes, we'd have to move from a patch to a major release as we're requiring users to update their version of next. If they don't, peer dep resolution would fail while they try to install the plugin.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah yeah good point. I won't force that upon people & just fix in our examples / integration-tests instead to resolve the vulnerability - thanks!
Bump version of
nextto resolve vulnerabilitiesCloses https://github.com/codecov/internal-issues/issues/929
Closes https://github.com/codecov/internal-issues/issues/935
Due 11/18/24