chore: Resolve rollup vuln #191
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found.
📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files
☔ View full report in Codecov by Sentry. |
Bundle ReportChanges will decrease total bundle size by 42.02kB (-1.51%) ⬇️. This is within the configured threshold ✅ Detailed changes
|
Bundle ReportChanges will increase total bundle size by 43.11kB (0.75%) ⬆️. This is within the configured threshold ✅ Detailed changes
|
packages/rollup-plugin/package.json
Outdated
| }, | ||
| "peerDependencies": { | ||
| "rollup": "3.x || 4.x" | ||
| "rollup": ">=3.29.5 <4.0.0 || >=4.22.4 <5.0.0" |
There was a problem hiding this comment.
@suejung-sentry are we able to rollback to the prior implementation of peer deps declarations?
With these changes, we'd have to move from a patch to a major release as we're requiring users to update their version of rollup. If they don't, peer dep resolution would fail while they try to install the plugin.
There was a problem hiding this comment.
good catch - fixed!
| { | ||
| "gzipSize": 98808, | ||
| "name": "main-H2_1FSsQ.js", | ||
| "name": "main-Bz9ahex4.js", |
There was a problem hiding this comment.
looks like these chunk names get regenerated with the new version of rollup
Resolve vulnerability in rollup (resolved versions - 4.22.4, 3.29.5)
Closes https://github.com/codecov/internal-issues/issues/931