Skip to content

Conversation

@suejung-sentry
Copy link
Contributor

@suejung-sentry suejung-sentry commented Nov 15, 2024

Use a more recent version of the codecov-rollup plugin. This also upgrades to rollup 3.29.5

Follows up to https://github.com/codecov/internal-issues/issues/931

@codecov-notifications
Copy link

codecov-notifications bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Components Coverage Δ
Plugin core 97.02% <ø> (ø)
Rollup plugin 10.81% <ø> (ø)
Vite plugin 11.02% <ø> (ø)
Webpack plugin 49.88% <ø> (ø)

📢 Thoughts on this report? Let us know!

@codecov
Copy link

codecov bot commented Nov 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 79.06%. Comparing base (2234eb0) to head (eb43d2a).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
Components Coverage Δ
Plugin core 97.02% <ø> (ø)
Rollup plugin 10.81% <ø> (ø)
Vite plugin 11.02% <ø> (ø)
Webpack plugin 49.88% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-staging
Copy link

codecov-staging bot commented Nov 15, 2024

Bundle Report

Changes will decrease total bundle size by 1.75kB (-0.06%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
@codecov/vite-plugin-esm 1.24kB 1.09kB (-46.82%) ⬇️
@codecov/rollup-plugin-esm 1.3kB 1.03kB (-44.14%) ⬇️
@codecov/webpack-plugin-cjs 4.47kB 57 bytes (1.29%) ⬆️
@codecov/sveltekit-plugin-esm 1.09kB 198 bytes (22.22%) ⬆️
@codecov/remix-vite-plugin-esm 1.09kB 133 bytes (13.9%) ⬆️
@codecov/webpack-plugin-esm 3.36kB 14 bytes (-0.42%) ⬇️

@codecov
Copy link

codecov bot commented Nov 15, 2024

Bundle Report

Changes will decrease total bundle size by 2.4kB (-0.04%) ⬇️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
@codecov/vite-plugin-esm 1.24kB 1.09kB (-46.82%) ⬇️
@codecov/rollup-plugin-esm 1.3kB 1.03kB (-44.14%) ⬇️
@codecov/sveltekit-plugin-esm 891 bytes 198 bytes (-18.18%) ⬇️
@codecov/webpack-plugin-cjs 4.47kB 57 bytes (1.29%) ⬆️
@codecov/solidstart-plugin-esm 949 bytes 142 bytes (-13.02%) ⬇️
@codecov/example-sveltekit-app-client-esm 715.09kB 2 bytes (-0.0%) ⬇️

@suejung-sentry suejung-sentry changed the title chore: Fix rollup versions in lockfile chore: Fix rollup versions Nov 15, 2024
@suejung-sentry suejung-sentry changed the title chore: Fix rollup versions chore: Upgrade codecov plugin versions in our uploads Dec 2, 2024
@suejung-sentry suejung-sentry merged commit 072682c into main Dec 2, 2024
62 checks passed
@suejung-sentry suejung-sentry deleted the sshin/chore/rollup-2 branch December 2, 2024 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants