Skip to content

Conversation

@nicholas-codecov
Copy link

Description

This PR removes the solid-start package from the integration tests, to remove a child dep we're not using. I added in a changeset because of the shared lockfile and the potential downstream that something else may be updated in a package.

Notable Changes

  • Removed solid-start package
  • Moved dev package to the devDependencies section
  • Update lockfile

@codecov-notifications
Copy link

codecov-notifications bot commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

Components Coverage Δ
Plugin core 98.04% <ø> (ø)
Rollup plugin 8.69% <ø> (ø)
Vite plugin 8.69% <ø> (ø)
Webpack plugin 57.69% <ø> (ø)

📢 Thoughts on this report? Let us know!

@codecov
Copy link

codecov bot commented Jan 20, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 81.23%. Comparing base (1ba06c9) to head (001d6b7).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
Components Coverage Δ
Plugin core 98.04% <ø> (ø)
Rollup plugin 8.69% <ø> (ø)
Vite plugin 8.69% <ø> (ø)
Webpack plugin 57.69% <ø> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-staging
Copy link

codecov-staging bot commented Jan 20, 2025

Bundle Report

Changes will increase total bundle size by 1.47kB (0.02%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
@codecov/bundle-analyzer-esm 3.45kB 347 bytes (11.17%) ⬆️
@codecov/webpack-plugin-esm 3.89kB 499 bytes (14.73%) ⬆️
@codecov/astro-plugin-esm 1.48kB 619 bytes (71.81%) ⬆️

@nicholas-codecov nicholas-codecov merged commit 553176a into main Jan 20, 2025
69 checks passed
@nicholas-codecov nicholas-codecov deleted the gh-int-1127-chore-remove-unused-solidstart-plugin branch January 20, 2025 17:12
@codecov
Copy link

codecov bot commented Jan 20, 2025

Bundle Report

Bundle size has no change ✅

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants