Skip to content

feat: Inline @sentry/core dependency #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jan 27, 2025
Merged

feat: Inline @sentry/core dependency #242

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
e73ab21
feat: Inline `@sentry/core` dependency
mydea Jan 23, 2025
d2a3d95
update lockfile
nsdeschenes Jan 24, 2025
9f48abe
add in changeset
nsdeschenes Jan 24, 2025
c2a15a3
enable debug mode for cli example
nsdeschenes Jan 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 19 additions & 1 deletion packages/bundler-plugin-core/build.config.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,25 @@ export default defineBuildConfig({
},
},
hooks: {
"rollup:options": (_ctx, opts) => {
"rollup:options": (ctx, opts) => {
// We want to ensure that `@sentry/core` is not externalized
// So we do not ship this dependency to users, as this may lead to conflicts with their installed Sentry versions
// TODO: When unbuild is updated to 3.3.0, this can be simplified by configuring `inlineDependencies`
// See: https://github.com/unjs/unbuild/releases/tag/v3.3.0
// Inspired by https://github.com/nuxt/nuxt/blob/f0ce20388d2ab533eba016de0565c150ea3c5172/packages/schema/build.config.ts#L23-L34
ctx.options.rollup.dts.respectExternal = false;
const isExternal = opts.external as (
id: string,
importer?: string,
isResolved?: boolean,
) => boolean;
opts.external = (source, importer, isResolved) => {
if (source === "@sentry/core") {
return false;
}
return isExternal(source, importer, isResolved);
};

if (process.env.PLUGIN_CODECOV_TOKEN && Array.isArray(opts.plugins)) {
// eslint-disable-next-line @typescript-eslint/no-unsafe-call, @typescript-eslint/no-floating-promises
opts.plugins = [
Expand Down
2 changes: 1 addition & 1 deletion packages/bundler-plugin-core/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,14 +41,14 @@
"dependencies": {
"@actions/core": "^1.10.1",
"@actions/github": "^6.0.0",
"@sentry/core": "^8.42.0",
"chalk": "4.1.2",
"semver": "^7.5.4",
"unplugin": "^1.10.1",
"zod": "^3.22.4"
},
"devDependencies": {
"@octokit/webhooks-definitions": "^3.67.3",
"@sentry/core": "^8.42.0",
"@types/node": "^20.11.15",
"@types/semver": "^7.5.6",
"@vitest/coverage-v8": "^2.1.8",
Expand Down
Loading