fix: typo affecting commit and compareSHA #257
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found.
📢 Thoughts on this report? Let us know! |
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files
☔ View full report in Codecov by Sentry. |
Bundle ReportChanges will increase total bundle size by 306.07kB (4.05%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: @codecov/vite-plugin-esmAssets Changed:
view changes for bundle: @codecov/rollup-plugin-esmAssets Changed:
view changes for bundle: @codecov/nuxt-plugin-esmAssets Changed:
view changes for bundle: @codecov/astro-plugin-esmAssets Changed:
view changes for bundle: @codecov/webpack-plugin-esmAssets Changed:
view changes for bundle: @codecov/example-astro-app-server-esmAssets Changed:
view changes for bundle: @codecov/solidstart-plugin-esmAssets Changed:
view changes for bundle: @codecov/bundler-plugin-core-esmAssets Changed:
Files in
view changes for bundle: @codecov/nextjs-webpack-plugin-esmAssets Changed:
view changes for bundle: @codecov/remix-vite-plugin-esmAssets Changed:
view changes for bundle: @codecov/example-next-app-client-array-pushAssets Changed:
view changes for bundle: @codecov/example-sveltekit-app-client-esmAssets Changed:
view changes for bundle: @codecov/sveltekit-plugin-esmAssets Changed:
view changes for bundle: @codecov/example-sveltekit-app-server-esmAssets Changed:
view changes for bundle: @codecov/example-next-15-app-client-array-pushAssets Changed:
view changes for bundle: @codecov/bundler-plugin-core-cjsAssets Changed:
Files in
view changes for bundle: @codecov/example-astro-5-app-server-esmAssets Changed:
|
Bundle ReportChanges will decrease total bundle size by 13.4kB (-0.17%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: @codecov/bundler-plugin-core-cjsAssets Changed:
Files in
view changes for bundle: @codecov/remix-vite-plugin-esmAssets Changed:
view changes for bundle: @codecov/bundler-plugin-core-esmAssets Changed:
view changes for bundle: @codecov/nuxt-plugin-esmAssets Changed:
view changes for bundle: @codecov/example-sveltekit-app-server-esmAssets Changed:
view changes for bundle: @codecov/solidstart-plugin-esmAssets Changed:
view changes for bundle: @codecov/example-next-15-app-client-array-pushAssets Changed:
view changes for bundle: @codecov/example-sveltekit-app-client-esmAssets Changed:
view changes for bundle: @codecov/astro-plugin-esmAssets Changed:
view changes for bundle: @codecov/sveltekit-plugin-esmAssets Changed:
view changes for bundle: @codecov/bundle-analyzer-esmAssets Changed:
view changes for bundle: @codecov/example-astro-app-server-esmAssets Changed:
view changes for bundle: @codecov/vite-plugin-esmAssets Changed:
view changes for bundle: @codecov/nextjs-webpack-plugin-esmAssets Changed:
view changes for bundle: @codecov/example-next-app-client-array-pushAssets Changed:
view changes for bundle: @codecov/rollup-plugin-esmAssets Changed:
view changes for bundle: @codecov/example-astro-5-app-server-esmAssets Changed:
|
spalmurray
reviewed
May 5, 2025
|
|
||
| if (res.status !== 200) { | ||
| debug(`Failed to get job URL: ${res.status}`, { enabled: output.debug }); | ||
| debug(`Failed to get job U1RL: ${res.status}`, { enabled: output.debug }); |
spalmurray
reviewed
May 5, 2025
| const payload = context.payload as PullRequestEvent; | ||
| commit = payload.pull_request.head.sha; | ||
| } else if ("merge_group" === context.eventName) { | ||
| const payload = context.payload as MergeGroupEvent; |
There was a problem hiding this comment.
is it reasonable to write tests for these?
spalmurray
approved these changes
May 5, 2025
spalmurray
left a comment
spalmurray
left a comment
There was a problem hiding this comment.
couple comments, lgtm otherwise. Note that there's a whole process for releasing new versions that we'll need to do after this is merged
i also added checks for the merge group event just in case
suejung-sentry
approved these changes
May 5, 2025
|
|
||
| const context = GitHub.context; | ||
| let commit = envs?.GITHUB_SHA; | ||
| if (["pull_request", " pull_request_target"].includes(context.eventName)) { |
Contributor
There was a problem hiding this comment.
nice catch on that hidden typo
| head: { | ||
| sha: "test-head-sha", | ||
| label: headLabel, | ||
| if (["pull_request", "pull_request_target"].includes(eventName)) { |
Contributor
There was a problem hiding this comment.
src/utils/providers/tests/GitHubActions.test.ts > GitHub Actions Params > gets correct params for a push event
Saw there is a failing unit test ^. For that, I think you can add "" for the mock creator here like if (["pull_request", "pull_request_target", ""].includes(eventName)) {.
That is to handle the case of setup({ eventName: "" }); in the "gets correct params for a push event" test.
| }, | ||
| "devDependencies": { | ||
| "@octokit/webhooks-definitions": "^3.67.3", | ||
| "@octokit/webhooks-types": "^7.6.1", |
Contributor
There was a problem hiding this comment.
nice, thanks for moving this over
| if (["pull_request", "pull_request_target"].includes(context.eventName)) { | ||
| const payload = context.payload as PullRequestEvent; | ||
| compareSha = payload.pull_request.base.sha; | ||
| } else if ("merge_group" === context.eventName) { |
Contributor
There was a problem hiding this comment.
I'll defer to @JerrySentry - any backend issues if we use the synthetic merge group commit sha to upload bundle sizes? I tried to find the history but seem to recall an issue in the past related to that
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@octokit/webhook-definitionswas deprecated so i changed it to use@octokit/webhook-types(which has the definition for the MergeGroupEvent)