Skip to content

fix: Migrate from isCached to cacheConfig #3718

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Feb 18, 2025
Merged

fix: Migrate from isCached to cacheConfig #3718

merged 5 commits into from
Feb 18, 2025

Conversation

@nicholas-codecov
Copy link
Contributor

@nicholas-codecov nicholas-codecov commented Feb 10, 2025 •
edited
Loading

Description

This PR migrates the usage of isCached to the new cacheConfig field being introduced in the API.

Requires: codecov/codecov-api#1148

Notable Changes

  • Update query, and validation schema
  • Update mutation, and validation schema
  • Update usage in the cache config modal
  • Update tests

@codecov-staging
Copy link

codecov-staging bot commented Feb 10, 2025 •
edited
Loading

Bundle Report

Changes will increase total bundle size by 38 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-staging-system 6.26MB 19 bytes (0.0%) ⬆️
gazebo-staging-esm 6.31MB 19 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: gazebo-staging-system

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/ConfigureCachedBundleModal-legacy.*.js 19 bytes 8.12kB 0.23%

Files in assets/ConfigureCachedBundleModal-legacy.*.js:

  • ./src/services/bundleAnalysis/useUpdateBundleCache.tsx → Total Size: 2.75kB

  • ./src/pages/RepoPage/shared/ConfigureCachedBundleModal/ConfigureCachedBundleModal.tsx → Total Size: 7.32kB

  • ./src/services/bundleAnalysis/CachedBundlesQueryOpts.tsx → Total Size: 3.56kB

view changes for bundle: gazebo-staging-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/ConfigureCachedBundleModal.*.js 19 bytes 8.55kB 0.22%

Files in assets/ConfigureCachedBundleModal.*.js:

  • ./src/services/bundleAnalysis/useUpdateBundleCache.tsx → Total Size: 2.75kB

  • ./src/services/bundleAnalysis/CachedBundlesQueryOpts.tsx → Total Size: 3.56kB

  • ./src/pages/RepoPage/shared/ConfigureCachedBundleModal/ConfigureCachedBundleModal.tsx → Total Size: 7.3kB

@codecov
Copy link

codecov bot commented Feb 10, 2025 •
edited
Loading

Bundle Report

Changes will increase total bundle size by 38 bytes (0.0%) ⬆️. This is within the configured threshold ✅

Detailed changes
Bundle name Size Change
gazebo-production-system 6.26MB 19 bytes (0.0%) ⬆️
gazebo-production-esm 6.31MB 19 bytes (0.0%) ⬆️

Affected Assets, Files, and Routes:

view changes for bundle: gazebo-production-system

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/ConfigureCachedBundleModal-legacy.*.js 19 bytes 8.12kB 0.23%

Files in assets/ConfigureCachedBundleModal-legacy.*.js:

  • ./src/pages/RepoPage/shared/ConfigureCachedBundleModal/ConfigureCachedBundleModal.tsx → Total Size: 7.32kB

  • ./src/services/bundleAnalysis/CachedBundlesQueryOpts.tsx → Total Size: 3.56kB

  • ./src/services/bundleAnalysis/useUpdateBundleCache.tsx → Total Size: 2.75kB

view changes for bundle: gazebo-production-esm

Assets Changed:

Asset Name Size Change Total Size Change (%)
assets/ConfigureCachedBundleModal.*.js 19 bytes 8.55kB 0.22%

Files in assets/ConfigureCachedBundleModal.*.js:

  • ./src/services/bundleAnalysis/CachedBundlesQueryOpts.tsx → Total Size: 3.56kB

  • ./src/services/bundleAnalysis/useUpdateBundleCache.tsx → Total Size: 2.75kB

  • ./src/pages/RepoPage/shared/ConfigureCachedBundleModal/ConfigureCachedBundleModal.tsx → Total Size: 7.3kB

@codecov
Copy link

codecov bot commented Feb 10, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.84%. Comparing base (9227c55) to head (56086bf).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #3718   +/-   ##
=======================================
  Coverage   98.84%   98.84%           
=======================================
  Files         824      824           
  Lines       14897    14897           
  Branches     4239     4231    -8     
=======================================
  Hits        14725    14725           
  Misses        166      166           
  Partials        6        6
Files with missing lines Coverage Δ
...reCachedBundleModal/ConfigureCachedBundleModal.tsx 100.00% <ø> (ø)
...services/bundleAnalysis/CachedBundlesQueryOpts.tsx 100.00% <100.00%> (ø)
...c/services/bundleAnalysis/useUpdateBundleCache.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.69% <ø> (ø)
Pages 98.51% <ø> (ø)
Services 99.24% <100.00%> (ø)
Shared 99.37% <ø> (ø)
UI 99.07% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9227c55...56086bf. Read the comment docs.

@codecov-notifications
Copy link

codecov-notifications bot commented Feb 10, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3718   +/-   ##
=======================================
  Coverage   98.84%   98.84%           
=======================================
  Files         824      824           
  Lines       14897    14897           
  Branches     4231     4239    +8     
=======================================
  Hits        14725    14725           
  Misses        166      166           
  Partials        6        6
Files with missing lines Coverage Δ
...reCachedBundleModal/ConfigureCachedBundleModal.tsx 100.00% <ø> (ø)
...services/bundleAnalysis/CachedBundlesQueryOpts.tsx 100.00% <100.00%> (ø)
...c/services/bundleAnalysis/useUpdateBundleCache.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.69% <ø> (ø)
Pages 98.51% <ø> (ø)
Services 99.24% <100.00%> (ø)
Shared 99.37% <ø> (ø)
UI 99.07% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9227c55...56086bf. Read the comment docs.

@codecov-qa
Copy link

codecov-qa bot commented Feb 10, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.84%. Comparing base (9227c55) to head (56086bf).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3718   +/-   ##
=======================================
  Coverage   98.84%   98.84%           
=======================================
  Files         824      824           
  Lines       14897    14897           
  Branches     4239     4239           
=======================================
  Hits        14725    14725           
  Misses        166      166           
  Partials        6        6
Files with missing lines Coverage Δ
...reCachedBundleModal/ConfigureCachedBundleModal.tsx 100.00% <ø> (ø)
...services/bundleAnalysis/CachedBundlesQueryOpts.tsx 100.00% <100.00%> (ø)
...c/services/bundleAnalysis/useUpdateBundleCache.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.69% <ø> (ø)
Pages 98.51% <ø> (ø)
Services 99.24% <100.00%> (ø)
Shared 99.37% <ø> (ø)
UI 99.07% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9227c55...56086bf. Read the comment docs.

@codecov-public-qa
Copy link

codecov-public-qa bot commented Feb 10, 2025 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 98.84%. Comparing base (9227c55) to head (56086bf).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

@@           Coverage Diff           @@
##             main    #3718   +/-   ##
=======================================
  Coverage   98.84%   98.84%           
=======================================
  Files         824      824           
  Lines       14897    14897           
  Branches     4231     4231           
=======================================
  Hits        14725    14725           
  Misses        166      166           
  Partials        6        6
Files with missing lines Coverage Δ
...reCachedBundleModal/ConfigureCachedBundleModal.tsx 100.00% <ø> (ø)
...services/bundleAnalysis/CachedBundlesQueryOpts.tsx 100.00% <100.00%> (ø)
...c/services/bundleAnalysis/useUpdateBundleCache.tsx 100.00% <100.00%> (ø)
Components Coverage Δ
Assets 100.00% <ø> (ø)
Layouts 99.69% <ø> (ø)
Pages 98.51% <ø> (ø)
Services 99.24% <100.00%> (ø)
Shared 99.37% <ø> (ø)
UI 99.07% <ø> (ø)

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9227c55...56086bf. Read the comment docs.

@codecov-releaser
Copy link
Contributor

codecov-releaser commented Feb 10, 2025 •
edited
Loading

✅ Deploy preview for gazebo ready!

Previews expire after 1 month automatically.

Storybook

Commit Created Cloud Enterprise
d2dba8c Mon, 10 Feb 2025 17:05:40 GMT Expired Expired
8556482 Tue, 11 Feb 2025 19:39:36 GMT Expired Expired
56086bf Tue, 18 Feb 2025 14:59:53 GMT Cloud Enterprise

@nicholas-codecov nicholas-codecov marked this pull request as ready for review February 11, 2025 19:33
@nicholas-codecov nicholas-codecov added this pull request to the merge queue Feb 18, 2025
Merged via the queue into main with commit 3566f99 Feb 18, 2025
62 checks passed
@nicholas-codecov nicholas-codecov deleted the fix-change-bundle-cache-config-value branch February 18, 2025 16:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@spalmurray-codecov spalmurray-codecov spalmurray-codecov approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@nicholas-codecov @codecov-releaser @spalmurray-codecov @nsdeschenes