feat: Surface latest upload error for latest commit in a branch for tests tab #3722
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundle ReportChanges will increase total bundle size by 75.08kB (0.6%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: gazebo-staging-systemAssets Changed:
Files in
Files in
Files in
view changes for bundle: gazebo-staging-esmAssets Changed:
Files in
Files in
Files in
|
Bundle ReportChanges will increase total bundle size by 75.08kB (0.6%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: gazebo-production-systemAssets Changed:
Files in
Files in
Files in
view changes for bundle: gazebo-production-esmAssets Changed:
Files in
Files in
Files in
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
Additional details and impacted files@@ Coverage Diff @@
## main #3722 +/- ##
==========================================
- Coverage 98.84% 98.83% -0.02%
==========================================
Files 826 827 +1
Lines 14865 14896 +31
Branches 4231 4238 +7
==========================================
+ Hits 14694 14723 +29
- Misses 165 167 +2
Partials 6 6
... and 22 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #3722 +/- ##
==========================================
- Coverage 98.84% 98.83% -0.02%
==========================================
Files 826 827 +1
Lines 14865 14896 +31
Branches 4223 4230 +7
==========================================
+ Hits 14694 14723 +29
- Misses 165 167 +2
Partials 6 6
... and 22 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAttention: Patch coverage is
✅ All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #3722 +/- ##
==========================================
- Coverage 98.84% 98.83% -0.02%
==========================================
Files 826 827 +1
Lines 14865 14896 +31
Branches 4231 4238 +7
==========================================
+ Hits 14694 14723 +29
- Misses 165 167 +2
Partials 6 6
... and 22 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Contributor
Codecov ReportAttention: Patch coverage is ✅ All tests successful. No failed tests found.
@@ Coverage Diff @@
## main #3722 +/- ##
==========================================
- Coverage 98.84% 98.83% -0.02%
==========================================
Files 826 827 +1
Lines 14865 14896 +31
Branches 4223 4238 +15
==========================================
+ Hits 14694 14723 +29
- Misses 165 167 +2
Partials 6 6
... and 22 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
RulaKhaled
changed the title
ajay-sentry
reviewed
Feb 13, 2025
| @@ -0,0 +1,203 @@ | |||
| import { QueryClient, QueryClientProvider } from '@tanstack/react-query' | |||
Contributor
There was a problem hiding this comment.
I think we wanna use v5 of the library right?
Contributor
There was a problem hiding this comment.
Oh JK I guess we'd also have to update the hook as well
ajay-sentry
reviewed
Feb 13, 2025
| import { MetricsSection } from './MetricsSection' | ||
| import { SelectorSection } from './SelectorSection' | ||
|
|
||
| const FailedTestsErrorBanner = lazy(() => import('./FailedTestsErrorBanner')) |
Contributor
There was a problem hiding this comment.
I think we wanted to move away from lazy imports but I can't remember, but is this why we had to update the other test to async?
Contributor
Author
There was a problem hiding this comment.
I'll update so it matches the rest of the imported components! and yes sir^
ajay-sentry
reviewed
Feb 13, 2025
| ${links.tokenlessDocs} | ${'https://docs.codecov.com/docs/codecov-tokens#uploading-without-a-token'} | ||
| ${links.requireCIPassDocs} | ${'https://docs.codecov.com/docs/codecovyml-reference#codecovrequire_ci_to_pass'} | ||
| ${links.circleCIEnvVars} | ${'https://circleci.com/docs/set-environment-variable/#set-an-environment-variable-in-a-project'} | ||
| ${links.testAnalyticsTroubleshooting} | ${'https://docs.codecov.com/docs/test-analytics-beta#troubleshooting'} |
Contributor
There was a problem hiding this comment.
nit: the doc link shouldn't say beta anymore right?
Contributor
Author
There was a problem hiding this comment.
oh nice it redirects to https://docs.codecov.com/docs/test-analytics#troubleshooting I'll update it
ajay-sentry
reviewed
Feb 13, 2025
| .object({ | ||
| latestUploadError: z | ||
| .object({ | ||
| errorCode: z.nativeEnum(ErrorCodeEnum), |
Contributor
There was a problem hiding this comment.
At least with how it's defined in GQL, these two keys are nullable on the type: https://github.com/codecov/codecov-api/blob/659b4ecf8d4d36de52af4fa729f7f8972945dd48/graphql_api/types/commit/commit.graphql#L31-L35
Can we have parity between the two?
Contributor
Author
There was a problem hiding this comment.
I'll update API, it cannot be null in the DB 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
We want to reflect the latest upload error if head commit of a branch has a report upload / processing error.
Notable Changes
latestUploadErrorScreenshots
Moved it down as seen above but that's how all should look like:
closes: #2846
Link to Sample Entry
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.