-
Notifications
You must be signed in to change notification settings - Fork 36
feat: Add recently visited repo at top of list #3734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
8 commits
Select commit
Hold shift + click to select a range
e69e60f
feat: Add recently visited repo at top of list
calvin-codecov cdd403a
fix: Review changes
calvin-codecov fc989e1
fix: Add missing import
calvin-codecov 3ed5cd5
fix: Capitalize recently visited badge
calvin-codecov c574897
refactor: Change types
calvin-codecov 13d275c
fix: Fix tests
calvin-codecov 648e07c
test: fix tests
calvin-codecov fd464e6
Merge branch 'main' into cy/org_page_recently_visited
calvin-codecov File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -2,6 +2,7 @@ import { createColumnHelper } from '@tanstack/react-table' | |
|
|
||
| import { RepositoryResult } from 'services/repos/ReposQueryOpts' | ||
| import { formatTimeToNow } from 'shared/utils/dates' | ||
| import { transformStringToLocalStorageKey } from 'shared/utils/transformStringToLocalStorageKey' | ||
| import TotalsNumber from 'ui/TotalsNumber' | ||
|
|
||
| import NoRepoCoverage from './NoRepoCoverage' | ||
|
|
@@ -18,6 +19,9 @@ export const getReposColumnsHelper = ({ | |
| const columnHelper = createColumnHelper< | ||
| RepositoryResult & { isDemo?: boolean } | ||
| >() | ||
| const recentlyVisitedRepoName = localStorage.getItem( | ||
| `${transformStringToLocalStorageKey(owner)}_recently_visited` | ||
| ) | ||
| const nameColumn = columnHelper.accessor('name', { | ||
| header: 'Name', | ||
| id: 'name', | ||
|
|
@@ -39,6 +43,9 @@ export const getReposColumnsHelper = ({ | |
| showRepoOwner={!owner} | ||
| pageName={pageName} | ||
| disabledLink={!isCurrentUserPartOfOrg && !repo?.active} | ||
| isRecentlyVisited={ | ||
| !!recentlyVisitedRepoName && recentlyVisitedRepoName === repo?.name | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. similar question here with !!recentlyVisitedRepoName |
||
| } | ||
| /> | ||
| ) | ||
| }, | ||
|
|
||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
any taste for converting this file to TS? Hopefully not too bad since its only 100 lines (famous last words)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I actually started the conversion. All of the
repofields started complaining so I tabled it for now hahaThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lol fair enough, some of those can be pretty annoying