feat: Open coverage dropdown when linking from file explorer#3752
feat: Open coverage dropdown when linking from file explorer#3752calvin-codecov merged 4 commits intomainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3752 +/- ##
=======================================
Coverage 98.67% 98.67%
=======================================
Files 825 825
Lines 14841 14843 +2
Branches 4241 4251 +10
=======================================
+ Hits 14645 14647 +2
Misses 189 189
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3752 +/- ##
=======================================
Coverage 98.70% 98.70%
=======================================
Files 823 823
Lines 14801 14803 +2
Branches 4220 4230 +10
=======================================
+ Hits 14609 14611 +2
Misses 186 186
Partials 6 6
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3752 +/- ##
=======================================
Coverage 98.67% 98.67%
=======================================
Files 825 825
Lines 14841 14843 +2
Branches 4241 4243 +2
=======================================
+ Hits 14645 14647 +2
Misses 189 189
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Bundle ReportChanges will increase total bundle size by 168 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: gazebo-production-esmAssets Changed:
Files in
Files in
Files in
view changes for bundle: gazebo-production-systemAssets Changed:
Files in
Files in
Files in
|
Bundle ReportChanges will increase total bundle size by 164 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: gazebo-staging-esmAssets Changed:
Files in
Files in
Files in
view changes for bundle: gazebo-staging-systemAssets Changed:
Files in
Files in
Files in
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3752 +/- ##
=======================================
Coverage 98.67% 98.67%
=======================================
Files 825 825
Lines 14841 14843 +2
Branches 4241 4243 +2
=======================================
+ Hits 14645 14647 +2
Misses 189 189
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
calvin-codecov
force-pushed
the
cy/report_dropdown_default
branch
from
31298ff to
96a27ce
Compare
| {!isLoading && | ||
| active?.displayType === displayTypeParameter.list && | ||
| dataLength && <span>{dataLength} total files</span>} | ||
| !!dataLength && <span>{dataLength} total files</span>} |
There was a problem hiding this comment.
was this a separate bug fix?
| pageName="commitTreeView" | ||
| commitSha={commitSha} | ||
| queryParams={{ flags, components }} | ||
| queryParams={{ flags, components, dropdown: 'coverage' }} |
There was a problem hiding this comment.
this is the thing that actually does the fix right?
nicholas-codecov
left a comment
nicholas-codecov
left a comment
There was a problem hiding this comment.
One small nit to tidy up
| {!isLoading && | ||
| active?.displayType === displayTypeParameter.list && | ||
| dataLength && <span>{dataLength} total files</span>} | ||
| !!dataLength && <span>{dataLength} total files</span>} |
There was a problem hiding this comment.
Can this be moved to a ternary over && just so we don't accidentally render something we don't mean to, could render a 0 here 🙀
There was a problem hiding this comment.
Can read more here if you're interested: notion doc
calvin-codecov
force-pushed
the
cy/report_dropdown_default
branch
from
eaefca9 to
33900f2
Compare
4 participants
Description
codecov/engineering-team#3129
Note: our current mechanism to open a dropdown is with the query param
?dropdown=. There is an opportunity where we could change to always open coverage dropdown by default instead of only when it is designated but after consulting with Nick, I decided that this still makes the most sense for the time being as the dropdown trigger bars have summary information. If we were to always open the coverage dropdown in all scenarios, it could possibly push the bundle report dropdown too far down and could be a disservice to the user.Notable Changes
Screenshots
Link to Sample Entry
Legal Boilerplate
Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.