ref: Convert OptionButton and DisplayTypeButton to TS#3759
ref: Convert OptionButton and DisplayTypeButton to TS#3759spalmurray-codecov merged 3 commits intomainfrom
Conversation
Bundle ReportChanges will decrease total bundle size by 563 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: gazebo-production-esmAssets Changed:
Files in
Files in
view changes for bundle: gazebo-production-systemAssets Changed:
Files in
Files in
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3759 +/- ##
==========================================
- Coverage 98.67% 98.67% -0.01%
==========================================
Files 825 825
Lines 14843 14842 -1
Branches 4251 4244 -7
==========================================
- Hits 14647 14646 -1
Misses 189 189
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3759 +/- ##
==========================================
- Coverage 98.67% 98.67% -0.01%
==========================================
Files 825 825
Lines 14843 14842 -1
Branches 4251 4244 -7
==========================================
- Hits 14647 14646 -1
Misses 189 189
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3759 +/- ##
==========================================
- Coverage 98.67% 98.67% -0.01%
==========================================
Files 825 825
Lines 14843 14842 -1
Branches 4243 4244 +1
==========================================
- Hits 14647 14646 -1
Misses 189 189
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
spalmurray-codecov
force-pushed
the
spalmurray/DisplayTypeButton-ts
branch
from
ec8c8bc to
b8fb34c
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3759 +/- ##
==========================================
- Coverage 98.67% 98.67% -0.01%
==========================================
Files 825 825
Lines 14843 14842 -1
Branches 4251 4244 -7
==========================================
- Hits 14647 14646 -1
Misses 189 189
Partials 7 7
Continue to review full report in Codecov by Sentry.
|
|
|
||
| export const Default: Story = { | ||
| render: () => { | ||
| const [active, setActive] = useState<'Orym' | 'Chetney' | 'Imogen'>( |
There was a problem hiding this comment.
They were in the old storybook so just brought them over, but unfortunately I do know that they are characters from Critical Role 🤓
calvin-codecov
left a comment
calvin-codecov
left a comment
There was a problem hiding this comment.
LGTM after merge conflict resolution
| type Options = (typeof options)[number] | ||
|
|
||
| function initialState(urlParams) { | ||
| // useLocationParams is pain |
spalmurray-codecov
force-pushed
the
spalmurray/DisplayTypeButton-ts
branch
from
b8fb34c to
b0e13c1
Compare
Bundle ReportChanges will decrease total bundle size by 563 bytes (-0.0%) ⬇️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: gazebo-staging-esmAssets Changed:
Files in
Files in
view changes for bundle: gazebo-staging-systemAssets Changed:
Files in
Files in
|
6 participants
Converts OptionButton and DisplayTypeButton to TS. Some type shenanigans required, but a good time was had. Also got rid of their barrel files.
Part of codecov/engineering-team#2747