feat: Add rejectNetworkError to calls (part three)#3767
feat: Add rejectNetworkError to calls (part three)#3767nicholas-codecov merged 14 commits intomainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #3767 +/- ##
==========================================
- Coverage 98.68% 98.68% -0.01%
==========================================
Files 825 825
Lines 14835 14831 -4
Branches 4251 4250 -1
==========================================
- Hits 14640 14636 -4
Misses 188 188
Partials 7 7
... and 18 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
❌ 1 Tests Failed:
View the top 1 failed tests by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
Bundle ReportChanges will increase total bundle size by 620 bytes (0.01%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: gazebo-staging-systemAssets Changed:
Files in
Files in
Files in
view changes for bundle: gazebo-staging-esmAssets Changed:
Files in
Files in
Files in
|
Bundle ReportChanges will increase total bundle size by 620 bytes (0.01%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: gazebo-production-systemAssets Changed:
Files in
Files in
Files in
view changes for bundle: gazebo-production-esmAssets Changed:
Files in
Files in
Files in
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3767 +/- ##
==========================================
- Coverage 98.68% 98.68% -0.01%
==========================================
Files 825 825
Lines 14835 14831 -4
Branches 4243 4242 -1
==========================================
- Hits 14640 14636 -4
Misses 188 188
Partials 7 7
... and 18 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3767 +/- ##
==========================================
- Coverage 98.68% 98.68% -0.01%
==========================================
Files 825 825
Lines 14835 14831 -4
Branches 4251 4242 -9
==========================================
- Hits 14640 14636 -4
Misses 188 188
Partials 7 7
... and 18 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
| data: {}, | ||
| dev: 'useSingularImpactedFileComparison - 404 missing data', | ||
| } satisfies NetworkErrorObject) | ||
| // we can set to null, and use the error display message we currently have, rather than throwing |
There was a problem hiding this comment.
not sure I understand what's going on here. Can you provide some more context?
There was a problem hiding this comment.
so before we were throwing an error here rather than returning anything. However, in all locations where this is being used, we're checking to ensure data exists and is not a nullish value, and if it is, we display an error message.
spalmurray-codecov
left a comment
spalmurray-codecov
left a comment
There was a problem hiding this comment.
One question, but I trust you know what you're doing lol
nicholas-codecov
deleted the
gh-eng-3329-add-reject-network-error-to-calls-part-three
branch
4 participants
Description
This PR is part three in a series, where we're going through and updating our query requests to utilize the new
rejectNetworkErrorhelper function.Ticket: codecov/engineering-team#3329
Notable Changes
rejectNetworkError(see commits)useRepoComponentsArgs