feat: add all branches option to TA branch selector #3842
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundle ReportChanges will increase total bundle size by 325 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: gazebo-staging-systemAssets Changed:
Files in
Files in
view changes for bundle: gazebo-staging-esmAssets Changed:
Files in
Files in
|
Bundle ReportChanges will increase total bundle size by 325 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: gazebo-production-systemAssets Changed:
Files in
Files in
view changes for bundle: gazebo-production-esmAssets Changed:
Files in
Files in
|
This comment has been minimized.
This comment has been minimized.
❌ 8 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
❌ 8 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
❌ 8 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
❌ 8 Tests Failed:
View the top 3 failed test(s) by shortest run time
To view more test analytics, go to the Test Analytics Dashboard |
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
| selection = { | ||
| name: 'Select branch', | ||
| head: null, | ||
| console.log('selection', selection) |
Comment on lines
+313
to
+340
| To see data for the {testData?.defaultBranch} branch, merge your PR | ||
| into the {testData?.defaultBranch} branch. |
There was a problem hiding this comment.
Should there be some fallback copy if the default branch doesn't exist?
basically we're going to be encoding a null branch parameter as specifying "all branches". So if a user goes to `<service>/<owner>/<repo>/tests` they will no longer get redirected or told to select a branch, we'll first attempt to fetch the results for all branches from the API. This change will rely on the change to the API which changes the default value of the branch when it's undefined to fetch the "all branches" data instead of the repo's default branch's data.
joseph-sentry
force-pushed
the
joseph/all-branches
branch
from
49b51e0 to
06a7dff
Compare
![seer-by-sentry[bot]](https://avatars.githubusercontent.com/in/801464?s=60&v=4){kind=small}
Comment on lines
130
to
132
| failedTestsLink.path({ | ||
| branch: encodeURIComponent(item?.value), | ||
| }) |
This comment was marked as outdated.
This comment was marked as outdated.
Sorry, something went wrong.
also updates condition for showing error messages in failed tests table component
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
we want to allow users to not filter by any specific branch and aggregate the results from all branches
we also want to make this the default option when users land on the tests tab from now on
i'm putting this behind a feature flag because the backend is not capable of serving this data yet since it relies on the TA timescale data migration, and there's an equivalent API change that needs to be made for this to work correctly as well
fixed a thing where when users were searching through the branch selector for a specific branch we were still pinning the default branch to the top of the selection
also the all branches view has all the nice stuff that the default branch view has: metrics section, reset to default button, etc.