fix: Use new scheduled phase data for next bill price #3959
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3959 +/- ##
=======================================
Coverage 98.73% 98.73%
=======================================
Files 826 826
Lines 14970 14983 +13
Branches 4280 4292 +12
=======================================
+ Hits 14780 14793 +13
Misses 182 182
Partials 8 8
Continue to review full report in Codecov by Sentry.
|
Bundle ReportChanges will increase total bundle size by 100 bytes (0.0%) ⬆️. This is within the configured threshold ✅ Detailed changes
Affected Assets, Files, and Routes:view changes for bundle: gazebo-production-systemAssets Changed:
Files in
Files in
Files in
view changes for bundle: gazebo-production-esmAssets Changed:
Files in
Files in
Files in
|
| scheduledPhasePlanName === PlanMarketingNames.PRO | ||
| ? calculatePriceProPlan | ||
| : scheduledPhasePlanName === PlanMarketingNames.TEAM | ||
| ? calculatePriceTeamPlan | ||
| : calculatePriceSentryPlan |
There was a problem hiding this comment.
Checking against the marketing names here isn't ideal but it's good enough for our intents and situation. Ideally we would be sending plan name like "teamm" too but this would need another umbrella change.
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #3959 +/- ##
=======================================
Coverage 98.73% 98.73%
=======================================
Files 826 826
Lines 14970 14983 +13
Branches 4285 4287 +2
=======================================
+ Hits 14780 14793 +13
Misses 182 182
Partials 8 8
Continue to review full report in Codecov by Sentry.
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. @@ Coverage Diff @@
## main #3959 +/- ##
=======================================
Coverage 98.73% 98.73%
=======================================
Files 826 826
Lines 14970 14983 +13
Branches 4285 4287 +2
=======================================
+ Hits 14780 14793 +13
Misses 182 182
Partials 8 8
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
✅ Deploy preview for gazebo ready!Previews expire after 1 month automatically.
|
Codecov Report✅ All modified and coverable lines are covered by tests. @@ Coverage Diff @@
## main #3959 +/- ##
==========================================
+ Coverage 95.33% 98.73% +3.39%
==========================================
Files 826 826
Lines 14970 14983 +13
Branches 4285 4292 +7
==========================================
+ Hits 14272 14793 +521
+ Misses 618 182 -436
+ Partials 80 8 -72
... and 53 files with indirect coverage changes
Continue to review full report in Codecov by Sentry.
🚀 New features to boost your workflow:
|
FE followup to codecov/umbrella#569 to close https://linear.app/getsentry/issue/CCMRG-1859/billing-display-mismatch to use new GQL fields in the scheduledPhase object for more accurate upcoming bill price calculation if the customer has an upcoming plan that is different.
Note
Compute next bill price using upcoming
scheduledPhasefields, with schema/util additions and comprehensive tests.PaymentCard.jsxto calculate next bill via new helpercalculateNextBillPrice, prioritizingaccountDetails.scheduleDetail.scheduledPhase(usesbillingRate,baseUnitPrice,plan,quantity), with fallback to current plan data.useMemodependencies to includescheduledPhase.AccountDetailsSchemato includescheduledPhase.billingRateandscheduledPhase.baseUnitPrice.PlanMarketingNamestoshared/utils/billingfor plan name matching.PaymentCard.test.jsxwith cases covering scheduled phase transitions (Pro → Team, Team → Pro, Team → Sentry Pro) and various plan/billing scenarios (monthly/annual; Pro/Team/Sentry).Written by Cursor Bugbot for commit 89abd44. This will update automatically on new commits. Configure here.
Some examples
