ci: use same coverage/test result filenames as other repos #517
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #517 +/- ##
==========================================
- Coverage 90.50% 89.92% -0.58%
==========================================
Files 463 324 -139
Lines 13275 8989 -4286
Branches 2116 1585 -531
==========================================
- Hits 12014 8083 -3931
+ Misses 1140 845 -295
+ Partials 121 61 -60
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
matt-codecov
force-pushed
the
pr517
branch
2 times, most recently
from
e5557d2 to
b4f7fd1
Compare
| @@ -1,5 +1,6 @@ | |||
| [run] | |||
| branch = True | |||
| relative_files = True | |||
There was a problem hiding this comment.
🎉 nice!
I feel like this should be the default. If it were, we wouldn’t need all that PathFixer nonesense.
| run: | | ||
| docker-compose exec shared codecovcli -v upload-process --flag shared-docker-uploader --token ${{ secrets.CODECOV_ORG_TOKEN }} --fail-on-error | ||
| docker-compose exec shared codecovcli -v do-upload --report-type "test_results" --flag shared-docker-uploader --token ${{ secrets.CODECOV_ORG_TOKEN }} --fail-on-error | ||
| docker-compose exec shared codecovcli -v upload-process --flag shared-docker-uploader --file tests/unit.coverage.xml --token ${{ secrets.CODECOV_ORG_TOKEN }} --fail-on-error |
There was a problem hiding this comment.
Does shared not have the distinction between unit and integration tests, like the other repos do?
There was a problem hiding this comment.
i think some tests call themselves integration tests but it's not worked into the repo/CI currently. we should change that, and other things, so that we can reuse the workflows worker/api get to use
currently i am disturbing as little as possible so get things working in umbrella, and then we can assess whether to change shared to follow that pattern or change all three projects to use a more monorepo-aware CI structure
✅ Sentry found no issues in your recent changes ✅ |
useful for codecov/umbrella#4