Skip to content

feat: add_oidc#113

Merged
joseph-sentry merged 1 commit intomainfrom
joseph/test
Mar 11, 2025
Merged

feat: add_oidc#113
joseph-sentry merged 1 commit intomainfrom
joseph/test

Conversation

@joseph-sentry
Copy link
Copy Markdown
Contributor

@joseph-sentry joseph-sentry commented Mar 4, 2025

No description provided.

@codecov
Copy link
Copy Markdown

codecov bot commented Mar 4, 2025 •
edited
Loading

❌ 10 Tests Failed:

Tests completed Failed Passed Skipped
12 10 2 0
View the top 3 failed test(s) by shortest run time 
 fully covered
Stack Traces | 0s run time 
Error: expect(received).toEqual(expected) // deep equality

Expected: false
Received: true
    at Object.<anonymous> (.../demo/coverage-test/coverage.test.ts:10:39)
    at Promise.then.completed (.../jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../jest-circus/build/utils.js:231:10)
    at _callCircusTest (.../jest-circus/build/run.js:316:40)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at _runTest (.../jest-circus/build/run.js:252:3)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:126:9)
    at run (.../jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../jest-runner/build/runTest.js:367:16)
    at runTest (.../jest-runner/build/runTest.js:444:34)
 fully covered
Stack Traces | 0s run time 
Error: expect(received).toEqual(expected) // deep equality

Expected: false
Received: true
    at Object.<anonymous> (.../demo/coverage-test/coverage.test.ts:10:39)
    at Promise.then.completed (.../jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../jest-circus/build/utils.js:231:10)
    at _callCircusTest (.../jest-circus/build/run.js:316:40)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at _runTest (.../jest-circus/build/run.js:252:3)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:126:9)
    at run (.../jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../jest-runner/build/runTest.js:367:16)
    at runTest (.../jest-runner/build/runTest.js:444:34)
 subtracts 2 - 3 to equal -1
Stack Traces | 0s run time 
Error: expect(received).toBe(expected) // Object.is equality

Expected: 1
Received: -1
    at Object.<anonymous> (.../demo/calculator/calculator.test.ts:10:31)
    at Promise.then.completed (.../jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../jest-circus/build/utils.js:231:10)
    at _callCircusTest (.../jest-circus/build/run.js:316:40)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at _runTest (.../jest-circus/build/run.js:252:3)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:126:9)
    at run (.../jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../jest-runner/build/runTest.js:367:16)
    at runTest (.../jest-runner/build/runTest.js:444:34)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@codecov-staging
Copy link
Copy Markdown

codecov-staging bot commented Mar 4, 2025 •
edited
Loading

❌ 12 Tests Failed:

Tests completed Failed Passed Skipped
18 12 6 0
View the top 3 failed test(s) by shortest run time 
 subtracts 2 - 3 to equal -1
Stack Traces | 0s run time 
Error: expect(received).toBe(expected) // Object.is equality

Expected: 1
Received: -1
    at Object.<anonymous> (.../demo/calculator/calculator.test.ts:10:31)
    at Promise.then.completed (.../jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../jest-circus/build/utils.js:231:10)
    at _callCircusTest (.../jest-circus/build/run.js:316:40)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at _runTest (.../jest-circus/build/run.js:252:3)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:126:9)
    at run (.../jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../jest-runner/build/runTest.js:367:16)
    at runTest (.../jest-runner/build/runTest.js:444:34)
 subtracts 2 - 3 to equal -1
Stack Traces | 0s run time 
Error: expect(received).toBe(expected) // Object.is equality

Expected: 1
Received: -1
    at Object.<anonymous> (.../demo/calculator/calculator.test.ts:10:31)
    at Promise.then.completed (.../jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../jest-circus/build/utils.js:231:10)
    at _callCircusTest (.../jest-circus/build/run.js:316:40)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at _runTest (.../jest-circus/build/run.js:252:3)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:126:9)
    at run (.../jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../jest-runner/build/runTest.js:367:16)
    at runTest (.../jest-runner/build/runTest.js:444:34)
 subtracts 2 - 3 to equal -1
Stack Traces | 0s run time 
Error: expect(received).toBe(expected) // Object.is equality

Expected: 1
Received: -1
    at Object.<anonymous> (.../demo/calculator/calculator.test.ts:10:31)
    at Promise.then.completed (.../jest-circus/build/utils.js:298:28)
    at new Promise (<anonymous>)
    at callAsyncCircusFn (.../jest-circus/build/utils.js:231:10)
    at _callCircusTest (.../jest-circus/build/run.js:316:40)
    at processTicksAndRejections (node:internal/process/task_queues:95:5)
    at _runTest (.../jest-circus/build/run.js:252:3)
    at _runTestsForDescribeBlock (.../jest-circus/build/run.js:126:9)
    at run (.../jest-circus/build/run.js:71:3)
    at runAndTransformResultsToJestFormat (.../build/legacy-code-todo-rewrite/jestAdapterInit.js:122:21)
    at jestAdapter (.../build/legacy-code-todo-rewrite/jestAdapter.js:79:19)
    at runTestInternal (.../jest-runner/build/runTest.js:367:16)
    at runTest (.../jest-runner/build/runTest.js:444:34)

To view more test analytics, go to the Test Analytics Dashboard
📋 Got 3 mins? Take this short survey to help us improve Test Analytics.

@thomasrockhu-codecov
Copy link
Copy Markdown
Contributor

thomasrockhu-codecov commented Mar 4, 2025

@joseph-sentry can you test by adding a case here?

@joseph-sentry joseph-sentry force-pushed the joseph/test branch 3 times, most recently from 2d5970b to 728046f Compare March 4, 2025 19:17
thomasrockhu-codecov
thomasrockhu-codecov reviewed Mar 4, 2025
View reviewed changes
.github/workflows/main.yml Outdated
- name: Upload test results to Codecov (calculator) (staging) (oidc)
uses: ./
with:
use_oidc: true
Copy link
Copy Markdown
Contributor

@thomasrockhu-codecov thomasrockhu-codecov Mar 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this should fail given the URL is different?

Copy link
Copy Markdown
Contributor Author

@joseph-sentry joseph-sentry Mar 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i think it should be fine and staging should support oidc

Copy link
Copy Markdown
Contributor

@thomasrockhu-codecov thomasrockhu-codecov Mar 4, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@joseph-sentry oh sorry, I'm an idiot. I suspected that the url param wasn't given but it definitely is.

Can you do me a favor and just run it once without setting url to see that it fails? If so, I'm good with this and will approve

@joseph-sentry joseph-sentry force-pushed the joseph/test branch 3 times, most recently from c252918 to 032d0b4 Compare March 5, 2025 15:51
@Kobby-Bawuah Kobby-Bawuah mentioned this pull request Mar 6, 2025
Open
@joseph-sentry joseph-sentry force-pushed the joseph/test branch 6 times, most recently from dca4d3a to 897b9ba Compare March 11, 2025 17:19
@joseph-sentry
feat: add use_oidc option
f450025 
the OIDC token was previously not being validated in shelter in the
test results endpoint, but it should be from now on.
@joseph-sentry joseph-sentry merged commit f2dba72 into main Mar 11, 2025
7 checks passed
@thomasrockhu-codecov thomasrockhu-codecov deleted the joseph/test branch March 11, 2025 17:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@thomasrockhu-codecov thomasrockhu-codecov thomasrockhu-codecov approved these changes

@matt-codecov matt-codecov Awaiting requested review from matt-codecov

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@joseph-sentry @thomasrockhu-codecov