fix: "commits where fail" number calculation #354
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joseph-sentry
changed the title
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #354 +/- ##
==========================================
- Coverage 94.17% 94.17% -0.01%
==========================================
Files 1270 1272 +2
Lines 47088 47102 +14
Branches 1497 1497
==========================================
+ Hits 44344 44356 +12
- Misses 2438 2440 +2
Partials 306 306
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov Report❌ Patch coverage is
❌ Your patch status has failed because the patch coverage (70.58%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage. 📢 Thoughts on this report? Let us know! |
CodSpeed Performance ReportMerging #354 will not alter performanceComparing Summary
|
joseph-sentry
force-pushed
the
joseph/ta-fix-commits-failed
branch
from
63e52d5 to
37e6ae9
Compare
![seer-by-sentry[bot]](https://avatars.githubusercontent.com/in/801464?s=60&v=4){kind=small}
...red/django_apps/ta_timeseries/migrations/0028_branchtestaggregatedaily_testaggregatedaily.py
Outdated
Show resolved
Hide resolved
joseph-sentry
force-pushed
the
joseph/ta-fix-commits-failed
branch
from
37e6ae9 to
872724d
Compare
...red/django_apps/ta_timeseries/migrations/0028_branchtestaggregatedaily_testaggregatedaily.py
Outdated
Show resolved
Hide resolved
joseph-sentry
force-pushed
the
joseph/ta-fix-commits-failed
branch
4 times, most recently
from
fb3963b to
fdb706f
Compare
joseph-sentry
force-pushed
the
joseph/ta-fix-commits-failed
branch
3 times, most recently
from
4752941 to
e8d4189
Compare
I made a mistake in a previous migration where i wanted to run the creation of an index using timescale's with transaction_per_chunk, which is its alternative to create index concurrently, and since we let the hypertables be managed by django i created the index on the model, but django's state was never updated. so i introduce ts_create_index_on_managed_hypertable to avoid this situation in the future and introduce a migration to fix the mistake i had made before
this contains the update to the application logic that uses the new CAs we defined in the previous commit we're also improving the filtering of skipped tests by using information from the CAs which allows us to avoid doing more expensive queries during every API call we also use window function to calculate slow tests instead of subqueries I also choose to refactor the code out into modules for each type of data and a utils module for code reuse
joseph-sentry
force-pushed
the
joseph/ta-fix-commits-failed
branch
from
e8d4189 to
e04b4b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on #427
we have to store the individual commit shas in the aggregate to be able to
get an accurate number, otherwise we might double count and inflate the number
so we have to re-define the CAs to use an array_agg(distinct ...) then use our
custom array_merge_dedup aggregate function in the query that's run against the
CAs and we end up with a list of all the commit shas where there were failures
then we take the cardinality and coalesce with 0 in case a null appeared at any
point of the computation