Skip to content

Conversation

joseph-sentry
Copy link
Contributor

get rid of status_set_pending task since that's only used in a part of the github webhook handler that never gets called so its essentially dead code

get rid of unused logs in github webhook handler

add a log to check if any users are using the ci skip feature

Copy link

codecov bot commented Aug 8, 2025

Codecov Report

❌ Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 94.22%. Comparing base (07d60e2) to head (493c094).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
apps/worker/tasks/upload_finisher.py 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #392      +/-   ##
==========================================
- Coverage   94.22%   94.22%   -0.01%     
==========================================
  Files        1258     1257       -1     
  Lines       46605    46534      -71     
  Branches     1491     1491              
==========================================
- Hits        43914    43845      -69     
+ Misses       2386     2384       -2     
  Partials      305      305              
Flag Coverage Δ
apiunit 96.17% <100.00%> (+0.01%) ⬆️
sharedintegration 40.22% <ø> (-0.01%) ⬇️
sharedunit 89.00% <ø> (-0.01%) ⬇️
workerintegration 61.33% <0.00%> (-0.11%) ⬇️
workerunit 90.71% <0.00%> (-0.04%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-notifications
Copy link

codecov-notifications bot commented Aug 8, 2025

Codecov Report

❌ Patch coverage is 87.50000% with 1 line in your changes missing coverage. Please review.
✅ All tests successful. No failed tests found.

Files with missing lines Patch % Lines
apps/worker/tasks/upload_finisher.py 0.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (87.50%) is below the target coverage (90.00%). You can increase the patch coverage or adjust the target coverage.

📢 Thoughts on this report? Let us know!

Copy link

codspeed-hq bot commented Aug 8, 2025

CodSpeed Performance Report

Merging #392 will not alter performance

Comparing joey/ref-gh-webhooks (493c094) with main (07d60e2)

Summary

✅ 9 untouched benchmarks

Comment on lines 51 to 52
def __init__(self, *args, **kwargs):
super().__init__(*args, **kwargs)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is redundant since the super's init function will be called when the subclass doesn't define its own init function

get rid of status_set_pending task since that's only used in a part of
the github webhook handler that never gets called so its essentially
dead code

get rid of unused logs in github webhook handler

add a log to check if any users are using the ci skip feature
@joseph-sentry joseph-sentry added this pull request to the merge queue Aug 15, 2025
Merged via the queue into main with commit 4914dde Aug 15, 2025
49 of 51 checks passed
@joseph-sentry joseph-sentry deleted the joey/ref-gh-webhooks branch August 15, 2025 18:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants