Skip to content

Conversation

ElioDiNino
Copy link
Contributor

As the title says, this PR introduces an admin view for upload breadcrumbs. Photos below:

Expandable explainer

image

List page with search and filters

image

Detailed view (2 examples)

image image

@ElioDiNino ElioDiNino self-assigned this Aug 8, 2025
Copy link

codecov bot commented Aug 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.20%. Comparing base (aff0994) to head (704d042).
⚠️ Report is 1 commits behind head on main.
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #394      +/-   ##
==========================================
+ Coverage   94.18%   94.20%   +0.02%     
==========================================
  Files        1255     1256       +1     
  Lines       46320    46538     +218     
  Branches     1455     1489      +34     
==========================================
+ Hits        43625    43843     +218     
  Misses       2390     2390              
  Partials      305      305              
Flag Coverage Δ
apiunit 96.10% <100.00%> (+<0.01%) ⬆️
sharedintegration 40.22% <32.25%> (-0.14%) ⬇️
sharedunit 89.02% <100.00%> (+0.17%) ⬆️
workerintegration 61.46% <ø> (ø)
workerunit 90.74% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-notifications
Copy link

codecov-notifications bot commented Aug 8, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@ElioDiNino ElioDiNino force-pushed the ElioDiNino/upload-breadcrumbs-admin branch from ae32154 to 4bfed9c Compare August 8, 2025 20:56
Copy link

codspeed-hq bot commented Aug 8, 2025

CodSpeed Performance Report

Merging #394 will not alter performance

Comparing ElioDiNino/upload-breadcrumbs-admin (704d042) with main (5a06654)1

Summary

✅ 9 untouched benchmarks

Footnotes

  1. No successful run was found on main (aff0994) during the generation of this report, so 5a06654 was used instead as the comparison base. There might be some changes unrelated to this pull request in this report.

@ElioDiNino ElioDiNino force-pushed the ElioDiNino/upload-breadcrumbs-admin branch 2 times, most recently from 83b1e1c to 7a7195e Compare August 8, 2025 22:17
@ElioDiNino ElioDiNino requested a review from a team August 8, 2025 22:31
@ElioDiNino ElioDiNino marked this pull request as ready for review August 8, 2025 22:31
Copy link
Contributor

@joseph-sentry joseph-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you can address the comments in a followup

@ElioDiNino ElioDiNino force-pushed the ElioDiNino/upload-breadcrumbs-admin branch from 3012a8b to 25248af Compare August 11, 2025 20:31
Copy link
Contributor

@ajay-sentry ajay-sentry left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good! nice work

@ElioDiNino ElioDiNino force-pushed the ElioDiNino/upload-breadcrumbs-admin branch from 25248af to 4a2c021 Compare August 11, 2025 20:36
@ElioDiNino ElioDiNino force-pushed the ElioDiNino/upload-breadcrumbs-admin branch from 4a2c021 to 704d042 Compare August 12, 2025 14:02
@ElioDiNino ElioDiNino added this pull request to the merge queue Aug 12, 2025
Merged via the queue into main with commit b724fc8 Aug 12, 2025
133 of 139 checks passed
@ElioDiNino ElioDiNino deleted the ElioDiNino/upload-breadcrumbs-admin branch August 12, 2025 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants