Skip to content
This repository was archived by the owner on May 5, 2025. It is now read-only.

Conversation

@ajay-sentry
Copy link
Contributor

@ajay-sentry ajay-sentry commented Feb 11, 2025

This PR aims to fix the last reference of USERS_BASIC being referenced on the account model, and some broken tests from updating the shared hash with codecov/shared#510

Closes codecov/engineering-team#3347

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@github-actions
Copy link

github-actions bot commented Feb 11, 2025

This PR includes changes to shared. Please review them here: codecov/shared@986a097...016a756

@codecov
Copy link

codecov bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.53%. Comparing base (2e53a26) to head (da6e2be).
Report is 1 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1085   +/-   ##
=======================================
  Coverage   97.53%   97.53%           
=======================================
  Files         466      466           
  Lines       38205    38229   +24     
=======================================
+ Hits        37263    37287   +24     
  Misses        942      942           
Flag Coverage Δ
integration 42.88% <62.50%> (+<0.01%) ⬆️
unit 90.21% <95.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

⚠️ Impact Analysis from Codecov is deprecated and will be sunset on Jan 31 2025. See more

@codecov-notifications
Copy link

codecov-notifications bot commented Feb 11, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@github-actions
Copy link

✅ All tests successful. No failed tests were found.

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

@ajay-sentry ajay-sentry added this pull request to the merge queue Feb 11, 2025
Merged via the queue into main with commit 8d10492 Feb 11, 2025
26 of 27 checks passed
@ajay-sentry ajay-sentry deleted the Ajay/worker-plan-fixes-no-billing-plan branch February 11, 2025 23:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[TechDebt] Remove BillingPlan references in Worker

3 participants