This repository was archived by the owner on May 5, 2025. It is now read-only.
Bump sqlalchemy version
#1119
Open
Bump sqlalchemy version
#1119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Swatinem
force-pushed
the
swatinem/bump-sqlalchemy
branch
from
4f06e49 to
35f6cf5
Compare
giovanni-guidini
approved these changes
Mar 3, 2025
Contributor
|
I expected the changes required to make this move would be more than the few files that were changed, but now I see tests are failing 😅 |
Contributor
Author
|
The needed changes were a bit annoying, but not too bad :-) |
Swatinem
force-pushed
the
swatinem/bump-sqlalchemy
branch
from
990923a to
6a2ab84
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
✅ All tests successful. No failed tests found. Additional details and impacted files@@ Coverage Diff @@
## main #1119 +/- ##
==========================================
- Coverage 97.77% 97.77% -0.01%
==========================================
Files 444 444
Lines 36638 36637 -1
==========================================
- Hits 35823 35822 -1
Misses 815 815
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Codecov ReportAll modified and coverable lines are covered by tests ✅ ✅ All tests successful. No failed tests found. 📢 Thoughts on this report? Let us know! |
Swatinem
force-pushed
the
swatinem/bump-sqlalchemy
branch
from
6a2ab84 to
99a8bf5
Compare
✅ Sentry found no issues in your recent changes ✅ |
Previously, `worker` would pin this to v1.3, but that would then fail tests within `shared` in a common workspace, as some tests in `shared` depend on v1.4 features.
Swatinem
force-pushed
the
swatinem/bump-sqlalchemy
branch
from
99a8bf5 to
395fcfa
Compare
Contributor
✅ Sentry found no issues in your recent changes ✅ |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
workerwould pin this to v1.3, but that would then fail tests withinsharedin a common workspace, as some tests inshareddepend on v1.4 features.