Skip to content
This repository was archived by the owner on May 5, 2025. It is now read-only.

Conversation

@ajay-sentry
Copy link
Contributor

@ajay-sentry ajay-sentry commented Dec 26, 2024

This PR bumps the stripe version from 9.6 -> 11.4.1 and changes the API version from 4/24 -> 12/24.

Just wanted to get ahead of API changes since the last time we did this it was a huge pain... (6 years of updates all at once lol): codecov/codecov-api#569

Changelog

Stripe docs

Only breaking changes were from v11 where we now have a default 2 retries and timeout changed from 2 -> 5 seconds for the stripe client. I figure that's probably fine and we can keep the new default. V10 didn't have any breaking changes we would have been affected by.

Relates to codecov/codecov-api#1071

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.

@codecov
Copy link

codecov bot commented Dec 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 97.97%. Comparing base (0fd7a81) to head (d8b419a).
Report is 2 commits behind head on main.

✅ All tests successful. No failed tests found.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #981   +/-   ##
=======================================
  Coverage   97.97%   97.97%           
=======================================
  Files         444      444           
  Lines       35848    35850    +2     
=======================================
+ Hits        35122    35124    +2     
  Misses        726      726           
Flag Coverage Δ
integration 42.16% <100.00%> (+<0.01%) ⬆️
unit 90.61% <100.00%> (+<0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

⚠️ Impact Analysis from Codecov is deprecated and will be sunset on Jan 31 2025. See more

@codecov-notifications
Copy link

codecov-notifications bot commented Dec 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

@github-actions
Copy link

✅ All tests successful. No failed tests were found.

📣 Thoughts on this report? Let Codecov know! | Powered by Codecov

Copy link
Member

@nora-shap nora-shap left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We are using uv instead of pip-tools for handling requirements in worker - that's why theres multiple unrelated packages being changed in the .txt

Instead of pip-compile, please run uv pip compile requirements.in -o requirements.txt, that should sort it out :)

@ajay-sentry ajay-sentry added this pull request to the merge queue Dec 27, 2024
Merged via the queue into main with commit 0026a62 Dec 27, 2024
27 checks passed
@ajay-sentry ajay-sentry deleted the Ajay/update-stripe-to-latest branch December 27, 2024 19:01
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants